Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eureka to be compatible with jakartaee #1465

Merged
merged 15 commits into from
Sep 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/nebula-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# test against JDK 8
java: [ 8 ]
# test against JDK 11
java: [ 11 ]
name: CI with Java ${{ matrix.java }}
steps:
- uses: actions/checkout@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nebula-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Setup jdk 8
- name: Setup jdk 11
uses: actions/setup-java@v1
with:
java-version: 1.8
java-version: 11
- uses: actions/cache@v1
id: gradle-cache
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nebula-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v1
with:
java-version: 8
java-version: 11
- uses: actions/cache@v2
id: gradle-cache
with:
Expand Down
9 changes: 3 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -35,24 +35,21 @@ allprojects {
githubProjectName = 'eureka'

awsVersion = '1.11.277'
servletVersion = '2.5'
jerseyVersion = '1.19.1'
servletVersion = '5.0.0'
jettisonVersion = '1.4.0'
apacheHttpClientVersion = '4.5.3'
commonsConfigurationVersion = '1.10'
jsr305Version = '3.0.2'
guiceVersion = '4.1.0'
servoVersion = '0.12.21'
governatorVersion = '1.17.5'
archaiusVersion = '0.7.6'
jacksonVersion = '2.10.5'
jacksonDatabindVersion = '2.10.5.1'
woodstoxVersion = '5.2.1'

// test deps
jetty_version = '7.2.0.v20101020'
jetty_version = '11.0.11'
junit_version = '4.11'
mockitoVersion = '1.10.19'
mockitoVersion = '4.6.1'
mockserverVersion = '3.9.2'
}
}
Expand Down
2 changes: 0 additions & 2 deletions eureka-client-archaius2/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,4 @@ dependencies {
testCompile 'org.mortbay.jetty:jetty:6.1H.22'
testCompile "org.mockito:mockito-core:${mockitoVersion}"
testCompile "org.mock-server:mockserver-netty:${mockserverVersion}"
testCompile "com.netflix.archaius:archaius2-guice:${archaius2Version}"
testCompile "com.netflix.governator:governator:${governatorVersion}"
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import com.netflix.discovery.CommonConstants;
import com.netflix.discovery.internal.util.InternalPrefixedConfig;

import javax.inject.Inject;
import javax.inject.Singleton;
import jakarta.inject.Inject;
import jakarta.inject.Singleton;

import static com.netflix.appinfo.PropertyBasedAmazonInfoConfigConstants.*;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.netflix.appinfo;

import javax.inject.Inject;
import javax.inject.Provider;
import javax.inject.Singleton;
import jakarta.inject.Inject;
import jakarta.inject.Provider;
import jakarta.inject.Singleton;

import com.netflix.discovery.CommonConstants;
import org.slf4j.Logger;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import java.util.HashMap;
import java.util.Map;

import javax.inject.Inject;
import javax.inject.Singleton;
import jakarta.inject.Inject;
import jakarta.inject.Singleton;

import com.google.common.collect.Sets;
import com.netflix.archaius.api.Config;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.netflix.appinfo.AmazonInfo;

import javax.inject.Provider;
import jakarta.inject.Provider;

public interface AmazonInfoProviderFactory {
Provider<AmazonInfo> get();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.inject.Inject;
import javax.inject.Singleton;
import jakarta.inject.Inject;
import jakarta.inject.Singleton;
import java.util.regex.Matcher;
import java.util.regex.Pattern;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.inject.Inject;
import javax.inject.Singleton;
import jakarta.inject.Inject;
import jakarta.inject.Singleton;
import java.net.SocketTimeoutException;
import java.net.URL;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
import com.netflix.discovery.CommonConstants;
import com.netflix.discovery.DiscoveryManager;

import com.google.inject.Inject;
import javax.inject.Named;
import javax.inject.Provider;
import javax.inject.Singleton;
import jakarta.inject.Inject;
import jakarta.inject.Named;
import jakarta.inject.Provider;
import jakarta.inject.Singleton;

@Singleton
public class CustomAmazonInfoProviderInstanceConfigFactory implements EurekaInstanceConfigFactory {
Expand All @@ -19,7 +19,7 @@ public class CustomAmazonInfoProviderInstanceConfigFactory implements EurekaInst
private final Provider<AmazonInfo> amazonInfoProvider;
private EurekaInstanceConfig eurekaInstanceConfig;

@Inject(optional = true)
@Inject
@Named(CommonConstants.INSTANCE_CONFIG_NAMESPACE_KEY)
String instanceConfigNamespace;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
import java.util.Collections;
import java.util.List;

import com.google.inject.Inject;
import jakarta.inject.Inject;
import com.netflix.appinfo.EurekaAccept;
import com.netflix.archaius.api.Config;
import com.netflix.archaius.api.annotations.ConfigurationSource;
import com.netflix.discovery.internal.util.InternalPrefixedConfig;
import com.netflix.discovery.shared.transport.EurekaTransportConfig;

import javax.inject.Singleton;
import jakarta.inject.Singleton;

import static com.netflix.discovery.PropertyBasedClientConfigConstants.*;

Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package com.netflix.discovery.shared.transport;

import com.google.inject.Inject;
import jakarta.inject.Inject;
import com.netflix.archaius.api.Config;
import com.netflix.archaius.api.annotations.ConfigurationSource;
import com.netflix.discovery.CommonConstants;
import com.netflix.discovery.internal.util.InternalPrefixedConfig;

import javax.inject.Singleton;
import jakarta.inject.Singleton;

import static com.netflix.discovery.shared.transport.PropertyBasedTransportConfigConstants.*;

Expand Down
Loading