-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Plasma Mobile #121345
Add support for Plasma Mobile #121345
Conversation
#125156, which only package apps is ✔️ ready for reviewing. |
d48bd14
to
cb521d6
Compare
cb521d6
to
8eee03b
Compare
With this last force-push:
|
(Not pushed) Tried rebasing on #127389, but the upgrade to 5.22.3 does not seem to fix the notifications issue. Night color untested.
|
8eee03b
to
ca4f1d5
Compare
2058c9a
to
ddbd2ae
Compare
Rebased, #139459 and #139537 fixes the issues with the notification sizes. The other two known issues noted are not breaking. The "wifi long press" issue is a supposition that the action is wrong, without actually verifying on another Plarma Mobile distro. The night light issues are untested on real hardware. Given that #117036 is closed, I figure it's more likely to be fixed. I'm still assuming if it's broken that it would be broken on "full" Plasma with Wayland. Current status is:
|
ddbd2ae
to
588c74b
Compare
Last update made the Plasma Mobile independent from Plasma Desktop. Before it required needlessly enabling all of Plasma Desktop. I am gearing up to test on Mobile devices more in depth, since everything "generic" seems to just work at this point. |
I tested with this configuration: Mindavi/pinephone-nixos-config@122413a In general, seems to work ok. I can now properly login, sddm seems to work fine. It builds on the pinephone (everything that was not substituted from the cache, that is). I did see the keyboard crash, but I don't expect this is related to packaging. In general it seems to work ok, so not sure why it crashed sometimes.
Have not looked at the code otherwise. |
I don't know if there's a service that handles LEDs in Plasma Mobile. The green LED is simply the default state from Linux's initialization.
Could be missing fonts. With all the hardware working (except for flashlight / notification LEDs), it's looking good I guess. A thing to do would be checking if upstream manages LEDs, and how, and why it doesn't work if so. |
I cannot find any documentation on notification LEDs in plasma mobile, and the UI also doesn't seem to expose anything about it. So I think nothing is done with it. I've been using this a little bit since I reviewed this, and haven't found any major issues otherwise. I think this is good to go in. |
86bfb9a
to
84f5cc0
Compare
rebased, fix build issue with update to 5.23.3. @Mindavi do you want to / can you test again? I'll build and test again for |
This is used with the Plasma Mobile configuration to configure the system as upstream recommends.
84f5cc0
to
2f12f30
Compare
I'd like to, but I gave my pinephone to a friend to try it out, they are still waiting for their librem 5. Hope they can get some experience before they get it (if ever....). I'll probably get it back somewhere in the following weeks, but didn't really plan a date or anything. So I'll not be able to test soon, unfortunately. |
I can try this out on my pinephone this weekend if you'd like anything specific checking or just another person to test it (but don't feel you have to wait for my review if you feel ready to merge). It's updating now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the NixOS module look good to me! 👍
|
Seems to be basically functional, much better than last time I tested it. Lots of weird and wonderful bugs and quirks, but nothing that's obviously related to plasma mobile packaging rather than upstream bugs. Good to see this merged at last! |
✔️ This is pretty much ready for a final review.
Note that the first chunk of commits is in:
This includes work form #58370. Thank you @Slabity.
What this is
This includes the "basic" set of released applications from the Plasma Mobile project. In addition to the shell configuration, and the NixOS configuration to use Plasma Mobile.
Known issues
Probably not specific to Plasma Mobile
Notifications are "full-screen", probably is the same issue as Notifications and other popups are treated like "normal" windows on Plasma Wayland #118650As expected, fixed with the same solution that fixes Notifications and other popups are treated like "normal" windows on Plasma Wayland #118650.Night colors not working Night color is broken after updated to plasma 5.21 #117036FixedProbably specific to Plasma Mobile
Forced numeric passwords!!!!!This is an upstream issue.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @NixOS/qt-kde