Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kwin: unwrap executable name for resource name #139459

Merged
merged 1 commit into from
Oct 4, 2021
Merged

kwin: unwrap executable name for resource name #139459

merged 1 commit into from
Oct 4, 2021

Conversation

CertainLach
Copy link
Member

@CertainLach CertainLach commented Sep 25, 2021 •
edited
Loading

Motivation for this change

Meant to fix #118650, but doesn't helps for some reason

app_id is fixed, but notifications still works incorrectly

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@CertainLach
kwin: unwrap executable name for resource name
60679c1 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach CertainLach mentioned this pull request Sep 25, 2021
Closed
@CertainLach CertainLach marked this pull request as ready for review September 25, 2021 21:25
@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 25, 2021 •
edited
Loading

Result of nixpkgs-review pr 139459 at 60679c1 run on aarch64-linux 1

37 packages skipped due to time constraints:
  • kdev-php
  • kdev-python
  • kdevelop-unwrapped
  • libsForQt5.plasma-desktop (libsForQt515.plasma-desktop ,plasma5Packages.plasma-desktop)
  • libsForQt512.kde-cli-tools
  • libsForQt512.kdeplasma-addons
  • libsForQt512.khotkeys
  • libsForQt512.kinfocenter
  • libsForQt512.kmenuedit
  • libsForQt512.krohnkite
  • ...
15 packages built successfully:
  • libsForQt5.kde-cli-tools (libsForQt515.kde-cli-tools ,plasma5Packages.kde-cli-tools)
  • libsForQt5.kdeplasma-addons (libsForQt515.kdeplasma-addons ,plasma5Packages.kdeplasma-addons)
  • libsForQt5.khotkeys (libsForQt515.khotkeys ,plasma5Packages.khotkeys)
  • libsForQt5.kinfocenter (libsForQt515.kinfocenter ,plasma5Packages.kinfocenter)
  • libsForQt5.kmenuedit (libsForQt515.kmenuedit ,plasma5Packages.kmenuedit)
  • libsForQt5.krohnkite (libsForQt515.krohnkite ,plasma5Packages.krohnkite)
  • libsForQt5.kwin (libsForQt515.kwin ,plasma5Packages.kwin)
  • libsForQt5.kwin-dynamic-workspaces (libsForQt515.kwin-dynamic-workspaces ,plasma5Packages.kwin-dynamic-workspaces)
  • libsForQt5.kwin-tiling (libsForQt515.kwin-tiling ,plasma5Packages.kwin-tiling)
  • libsForQt5.parachute (libsForQt515.parachute ,plasma5Packages.parachute)
  • libsForQt5.plasma-browser-integration (libsForQt515.plasma-browser-integration ,plasma5Packages.plasma-browser-integration)
  • libsForQt5.plasma-disks (libsForQt515.plasma-disks ,plasma5Packages.plasma-disks)
  • libsForQt5.plasma-workspace (libsForQt515.plasma-workspace ,plasma5Packages.plasma-workspace)
  • libsForQt5.powerdevil (libsForQt515.powerdevil ,plasma5Packages.powerdevil)
  • libsForQt5.systemsettings (libsForQt515.systemsettings ,plasma5Packages.systemsettings)

Result of nixpkgs-review pr 139459 at 60679c1 run on x86_64-linux 1

38 packages skipped due to time constraints:
  • kdev-php
  • kdev-python
  • kdevelop
  • kdevelop-unwrapped
  • libsForQt5.plasma-desktop (libsForQt515.plasma-desktop ,plasma5Packages.plasma-desktop)
  • libsForQt5.powerdevil (libsForQt515.powerdevil ,plasma5Packages.powerdevil)
  • libsForQt512.kde-cli-tools
  • libsForQt512.kdeplasma-addons
  • libsForQt512.khotkeys
  • libsForQt512.kinfocenter
  • ...
15 packages built successfully:
  • libsForQt5.kde-cli-tools (libsForQt515.kde-cli-tools ,plasma5Packages.kde-cli-tools)
  • libsForQt5.kdeplasma-addons (libsForQt515.kdeplasma-addons ,plasma5Packages.kdeplasma-addons)
  • libsForQt5.khotkeys (libsForQt515.khotkeys ,plasma5Packages.khotkeys)
  • libsForQt5.kinfocenter (libsForQt515.kinfocenter ,plasma5Packages.kinfocenter)
  • libsForQt5.kmenuedit (libsForQt515.kmenuedit ,plasma5Packages.kmenuedit)
  • libsForQt5.krohnkite (libsForQt515.krohnkite ,plasma5Packages.krohnkite)
  • libsForQt5.kwin (libsForQt515.kwin ,plasma5Packages.kwin)
  • libsForQt5.kwin-dynamic-workspaces (libsForQt515.kwin-dynamic-workspaces ,plasma5Packages.kwin-dynamic-workspaces)
  • libsForQt5.kwin-tiling (libsForQt515.kwin-tiling ,plasma5Packages.kwin-tiling)
  • libsForQt5.parachute (libsForQt515.parachute ,plasma5Packages.parachute)
  • libsForQt5.plasma-browser-integration (libsForQt515.plasma-browser-integration ,plasma5Packages.plasma-browser-integration)
  • libsForQt5.plasma-disks (libsForQt515.plasma-disks ,plasma5Packages.plasma-disks)
  • libsForQt5.plasma-workspace (libsForQt515.plasma-workspace ,plasma5Packages.plasma-workspace)
  • libsForQt5.systemsettings (libsForQt515.systemsettings ,plasma5Packages.systemsettings)
  • wacomtablet

@samueldr samueldr mentioned this pull request Sep 27, 2021
Merged
10 tasks
samueldr
samueldr approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the same reservations I had while implementing it initially in #116549 (not a C++ nor Qt expert), approved. Tested with Plasma Mobile.

@CertainLach CertainLach mentioned this pull request Oct 2, 2021
Merged
10 tasks
@samueldr
Copy link
Member

samueldr commented Oct 3, 2021

@SuperSandro2000 whatever you are doing, whether manual or automatic, it is currently harmful for the completeness of git formated patches.

@ttuegel ttuegel merged commit 1ed5ee8 into NixOS:master Oct 4, 2021
@CertainLach CertainLach deleted the kwin-unwrap-executable-name branch February 6, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications and other popups are treated like "normal" windows on Plasma Wayland
5 participants
@CertainLach @r-rmcgibbo @samueldr @ttuegel @SuperSandro2000