-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][13.0] stock_location_zone migration #804
Conversation
0ebd565
to
e115b43
Compare
@guewen Code LGTM. Could you create tests of this module? |
* Allow copy of stock locations (was blocked by constraint on unique name) * Correct loop in _compute_name returning too early if a record had no parent with a 'location_name_format' * Rename field pick_type_id to picking_type_id for coherency * Add missing _description on stock.picking.zone * Correct location_name_format format when the record is a NewId
* Add copyright header * Add myself as contributor of stock_location_zone * Fix lint
It prevents other addons to work properly such as the vertical lift. We remove the constraint for now, maybe to be re-introduced later in a more permissive way.
* Compute the 'zone' fields in the same method * Remove the dependency on 'zone_location_id', which seems to take a lot of time if not an infinite loop
So we can use it in group-by and filters. Note that we can have several levels of areas... only the top-level will be used. This commit fixes the computed field dependencies: _compute_location_kind should have a dependency on both it's parent's location_kind and on its child_ids to know if we are in a bin. This can't work without triggering an infinite loop. The trick used here is to split the computation of 'zone_location_id + area_location_id' in one computed method, and move the computation of the kind in a different method with triggers an the current record's zone_location + area_location_id, but not on the parent. Plus the zone_location_id and area_location_id do not depend anymore on the parent's kind, which is the reason for the infinite loop.
e115b43
to
9cf7fd4
Compare
@guewen do you want to merge 12.0 first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, as Alpha for now it's sufficiant for now for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to add tests, but LG 👍
This PR has the |
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
It looks like something changed on |
Congratulations, your PR was merged at 81a97d3. Thanks a lot for contributing to OCA. ❤️ |
Migration of
stock_location_zone
, including #711