Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][13.0] stock_location_zone migration #804

Merged
merged 11 commits into from
Mar 23, 2020
Merged

[MIG][13.0] stock_location_zone migration #804

merged 11 commits into from
Mar 23, 2020

Commits on Mar 17, 2020

  1. [ADD] stock_location_zone

    @jbaudoux @guewen
    jbaudoux authored and guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    fa7961a View commit details
    Browse the repository at this point in the history

  2. Add corrections to stock_location_zone 

    * Allow copy of stock locations (was blocked by constraint on unique name)
* Correct loop in _compute_name returning too early if a record had no
parent with a 'location_name_format'
* Rename field pick_type_id to picking_type_id for coherency
* Add missing _description on stock.picking.zone
* Correct location_name_format format when the record is a NewId
    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    35400e5 View commit details
    Browse the repository at this point in the history

  3. Set Alpha development status 

    * Add copyright header
* Add myself as contributor of stock_location_zone
* Fix lint
    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    5c727f1 View commit details
    Browse the repository at this point in the history

  4. Rework stock_location_zone

    @grindtildeath @guewen
    grindtildeath authored and guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    7386a85 View commit details
    Browse the repository at this point in the history

  5. Remove unique constraint on location's name 

    It prevents other addons to work properly such as the vertical lift.
We remove the constraint for now, maybe to be re-introduced later in a
more permissive way.
    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    42bc215 View commit details
    Browse the repository at this point in the history

  6. Improve performance 

    * Compute the 'zone' fields in the same method
* Remove the dependency on 'zone_location_id', which seems to take
  a lot of time if not an infinite loop
    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    6011aae View commit details
    Browse the repository at this point in the history

  7. Add area location relation 

    So we can use it in group-by and filters. Note that we can have several
levels of areas... only the top-level will be used.

This commit fixes the computed field dependencies:
_compute_location_kind should have a dependency on both it's parent's
location_kind and on its child_ids to know if we are in a bin. This
can't work without triggering an infinite loop. The trick used here is
to split the computation of 'zone_location_id + area_location_id' in one
computed method, and move the computation of the kind in a different
method with triggers an the current record's zone_location +
area_location_id, but not on the parent.

Plus the zone_location_id and area_location_id do not depend anymore on
the parent's kind, which is the reason for the infinite loop.
    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    a4a84bd View commit details
    Browse the repository at this point in the history

  8. [UPD] Update stock_location_zone.pot

    @oca-travis @guewen
    oca-travis authored and guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    d1a05e9 View commit details
    Browse the repository at this point in the history

  9. [IMP] stock_location_zone: black, isort

    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f07e9d5 View commit details
    Browse the repository at this point in the history

  10. [MIG] stock_location_zone: Migration to 13.0

    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    f9eed07 View commit details
    Browse the repository at this point in the history

  11. run pre-commit with new prettiers

    @guewen
    guewen committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    9cf7fd4 View commit details
    Browse the repository at this point in the history