Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #135, where Edge Lists where not being generated for OGRE > 1.9 #162

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

sercero
Copy link
Collaborator

@sercero sercero commented Feb 19, 2023

Also:

  • Add option to enable debug logging
  • Minor fixes

This fixes issue #135

@paroj
Copy link
Member

paroj commented Feb 19, 2023

thanks for fixing. I wanted to take a look at this several times already, but never managed to actually do it

@paroj paroj merged commit 149509d into OGRECave:master Feb 19, 2023
@sercero
Copy link
Collaborator Author

sercero commented Feb 19, 2023

thanks for fixing. I wanted to take a look at this several times already, but never managed to actually do it

Glad to help.

Looking into this issue I came upon these options:

-O puqs    = Optimize vertex buffers for shaders.
             p converts POSITION to 16-bit floats
             q converts normal tangent and bitangent (28-36 bytes) to QTangents (8 bytes).
             u converts UVs to 16-bit floats.
             s make shadow mapping passes have their own optimized buffers. Overrides existing ones if any.
             S strips the buffers for shadow mapping (consumes less space and memory).

Is there something equivalent for OGRE v1?

Could this be ported to OgreXMLConverter?

@sercero sercero deleted the edge_lists branch February 19, 2023 23:34
@paroj
Copy link
Member

paroj commented Feb 20, 2023

Looking into this issue I came upon these options:

  • pu these have very only a very narrow use-case, as float16 only gives you 1024 different values. i.e. limits you to max 1024x1024 textures or an according volume for positions.
  • sS this is not applicable to Ogre1. Also, I dont think you gain much by using them.
  • q: there is -pack for Ogre1, that does something similar https://www.patreon.com/posts/vet-int-10-10-10-65546177 It also brings down storage of normals from 12 byte to 4 byte.

Could this be ported to OgreXMLConverter?

actually, similar options were kicked out of OgreXMLConverter after 1.9, to ensure it always does a 1:1 conversion between binary and XML. E.g. -pack and float16 conversion are lossy operations that store a different value then what you started with in XML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants