Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --all for exiting all active validators #3243

Open
5 of 7 tasks
KaloyanTanev opened this issue Aug 30, 2024 · 0 comments
Open
5 of 7 tasks

Add --all for exiting all active validators #3243

KaloyanTanev opened this issue Aug 30, 2024 · 0 comments
Assignees
@KaloyanTanev
Labels
protocol Protocol Team tickets

Comments

@KaloyanTanev
Copy link
Contributor

KaloyanTanev commented Aug 30, 2024 •
edited
Loading

🎯 Problem to be solved

Currently if we want to exit all active validators in the cluster, it is quite cumbersome process, having to specify every validator's PK or index. Having big number of validators (i.e.: 1000) makes this quite slow. It would be great if users can simply add --all flag and exit all active validators.

🛠️ Proposed solution

  • Add --all flag to available flags for the exit command
  • Add --all for exit sign command
  • Add --all for exit broadcast command
  • Add --all for exit fetch command

🧪 Tests

  • Tested by new automated unit tests
  • Manually tested on local Kurtosis devnet
  • Manually tested on test Holesky clusters

❌ Out of Scope

Exiting all validators using the VC. This ticket is only about implementing this for charon exits.
@KaloyanTanev KaloyanTanev added the enhancement New feature or request label Aug 30, 2024
@KaloyanTanev KaloyanTanev self-assigned this Aug 30, 2024
@KaloyanTanev KaloyanTanev added protocol Protocol Team tickets and removed enhancement New feature or request labels Aug 30, 2024
@KaloyanTanev KaloyanTanev mentioned this issue Sep 11, 2024
Merged
obol-bulldozer bot pushed a commit that referenced this issue Sep 12, 2024
@KaloyanTanev
*: add --all for exit sign command (#3272)
cbd39d3 
Add `--all` command for signing partial exits. This PR is one of a couple incoming PRs that will be for the `--all` functionality. Mind that the CLI flag is not enabled until all of them are implemented and merged.

category: feature
ticket: #3243
This was referenced Sep 17, 2024
Merged
Merged
gsora pushed a commit that referenced this issue Sep 18, 2024
@KaloyanTanev @gsora
*: add --all for exit sign command (#3272)
cce6f86 
Add `--all` command for signing partial exits. This PR is one of a couple incoming PRs that will be for the `--all` functionality. Mind that the CLI flag is not enabled until all of them are implemented and merged.

category: feature
ticket: #3243
obol-bulldozer bot pushed a commit that referenced this issue Sep 19, 2024
@KaloyanTanev
cmd: broadcast all exits (#3288)
cc0f14e 
Second part of adding the `--all` flag for exits.

This PR is for the `charon exit broadcast` command. Additionally, a flag `exitFromDir` is introduced so point to a directory with exit files.

category: feature
ticket: #3243
obol-bulldozer bot pushed a commit that referenced this issue Sep 19, 2024
@KaloyanTanev
cmd: fetch all exits (#3291)
a23fd53 
Third part of adding the `--all` flag for exits.

This PR is for the charon exit fetch command.

category: feature
ticket: #3243
@KaloyanTanev KaloyanTanev mentioned this issue Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaloyanTanev KaloyanTanev

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KaloyanTanev