Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add --all for exit sign command #3272

Merged
merged 1 commit into from
Sep 12, 2024
Merged

*: add --all for exit sign command #3272

merged 1 commit into from
Sep 12, 2024

Conversation

KaloyanTanev
Copy link
Contributor

Add --all command for signing partial exits. This PR is one of a couple incoming PRs that will be for the --all functionality. Mind that the CLI flag is not enabled until all of them are implemented and merged.

category: feature
ticket: #3243

@KaloyanTanev KaloyanTanev self-assigned this Sep 11, 2024
Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 58.88889% with 37 lines in your changes missing coverage. Please review.

Project coverage is 57.64%. Comparing base (af6f87b) to head (56ccaba).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
cmd/exit_sign.go 59.77% 27 Missing and 8 partials ⚠️
cmd/exit.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
- Coverage   57.68%   57.64%   -0.05%     
==========================================
  Files         211      211              
  Lines       30418    30478      +60     
==========================================
+ Hits        17547    17569      +22     
- Misses      10986    11014      +28     
- Partials     1885     1895      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return errors.Wrap(err, "could not sign exits for all validators")
}
} else {
exitBlobs, err = signSingleValidatorExit(ctx, config, eth2Cl, shares)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use signAllValidatorsExits here, and instead of passing all shares we pass a slice with the single share we're interested in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've been thinking about that, but when we are signing for single validator we are checking the config if the user passed pubkey or index or both, in exit all scenario we don't have none of those. We can still use the same function for both cases, but I will have to add some flags and checks which to determine if we have to check the config or not. It will make the code less readable imo.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 12, 2024
@obol-bulldozer obol-bulldozer bot merged commit cbd39d3 into main Sep 12, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/exit-all-sign branch September 12, 2024 16:07
gsora pushed a commit that referenced this pull request Sep 18, 2024
Add `--all` command for signing partial exits. This PR is one of a couple incoming PRs that will be for the `--all` functionality. Mind that the CLI flag is not enabled until all of them are implemented and merged.

category: feature
ticket: #3243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants