Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve script driver #10436

Merged
merged 3 commits into from
Nov 24, 2023
Merged

perf: improve script driver #10436

merged 3 commits into from
Nov 24, 2023

Conversation

jayzhang
Copy link
Member

@jayzhang jayzhang commented Nov 24, 2023 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Nov 24, 2023 •
edited
Loading

Codecov Report

Merging #10436 (5881a58) into dev (4a50152) will increase coverage by 0.00%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #10436   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files         445      445           
  Lines       25846    25860   +14     
  Branches     5086     5094    +8     
=======================================
+ Hits        22334    22348   +14     
  Misses       1831     1831           
  Partials     1681     1681
Files Coverage Δ
...x-core/src/component/driver/script/scriptDriver.ts 86.60% <93.33%> (+1.91%) ⬆️

kuojianlu
kuojianlu approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@kuojianlu kuojianlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Involve PM to review the wordings?

@jayzhang jayzhang merged commit c25dd42 into dev Nov 24, 2023
34 checks passed
@jayzhang jayzhang deleted the huajie/script-shell branch November 24, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siglud Siglud Siglud approved these changes

@hund030 hund030 hund030 approved these changes

@kuojianlu kuojianlu kuojianlu approved these changes

@LongOddCode LongOddCode LongOddCode approved these changes

@wenytang-ms wenytang-ms Awaiting requested review from wenytang-ms wenytang-ms is a code owner

@xzf0587 xzf0587 Awaiting requested review from xzf0587

@yukun-dong yukun-dong Awaiting requested review from yukun-dong

@JerryYangKai JerryYangKai Awaiting requested review from JerryYangKai

@eriolchan eriolchan Awaiting requested review from eriolchan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jayzhang @Siglud @hund030 @kuojianlu @LongOddCode