Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keyboard input in HTML In App Messagess #2187

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Aug 29, 2024

Description

One Line Summary

Enable keyboard input for text input fields in In App Messages

Details

The popupWindow needed to be marked as focusable for non banner IAMs. Banners should remain unfocusable to allow interaction with the app underneath the popup

popupWindow?.isFocusable = !displayPosition.isBanner

I also changed some force unwraps to ?. We never expect these to be null, but this is safer.

Motivation

Enable text input in IAMs

Scope

IAMs

Testing

Unit testing

n/a ui

Manual testing

Tested both HTML and block built IAMs with text input.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

This allows the keyboard to be displayed for text input in HTML IAMs
We want focusable on for non banner IAMs to support keyboard input, but we don't want it on for banners since it restricts interacting with the app underneath the banner
@emawby emawby requested a review from nan-li August 29, 2024 18:26
@emawby emawby merged commit b218b01 into main Sep 3, 2024
2 checks passed
@emawby emawby deleted the fix/keyboard_input_IAM branch September 3, 2024 16:05
@jinliu9508 jinliu9508 mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants