Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Keyboard input in HTML In App Messagess #2187

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix Keyboard input in HTML In App Messagess #2187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9166053
Make IAM popupWindow focusable
emawby Aug 29, 2024
8697cb7
Don't set focusable for banners
emawby Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...sages/src/main/java/com/onesignal/inAppMessages/internal/display/impl/InAppMessageView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ internal class InAppMessageView(

fun setWebView(webView: WebView) {
this.webView = webView
this.webView!!.setBackgroundColor(Color.TRANSPARENT)
this.webView?.setBackgroundColor(Color.TRANSPARENT)
}

fun setMessageController(messageController: InAppMessageViewListener?) {
Expand Down Expand Up @@ -277,10 +277,13 @@ internal class InAppMessageView(
if (hasBackground) WindowManager.LayoutParams.MATCH_PARENT else WindowManager.LayoutParams.WRAP_CONTENT,
false,
)
popupWindow!!.setBackgroundDrawable(ColorDrawable(Color.TRANSPARENT))
popupWindow!!.isTouchable = true
popupWindow?.setBackgroundDrawable(ColorDrawable(Color.TRANSPARENT))
popupWindow?.isTouchable = true
// Focusable allows keyboard input for HTML IAMs, but also prevents interacting under banners
popupWindow?.isFocusable = !displayPosition.isBanner

// NOTE: This is required for getting fullscreen under notches working in portrait mode
popupWindow!!.isClippingEnabled = false
popupWindow?.isClippingEnabled = false
var gravity = 0
if (!hasBackground) {
gravity =
Expand All @@ -299,7 +302,7 @@ internal class InAppMessageView(
popupWindow!!,
displayType,
)
popupWindow!!.showAtLocation(
popupWindow?.showAtLocation(
currentActivity!!.window.decorView.rootView,
gravity,
0,
Expand Down
Loading