-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/36 variable recurring payments for 3 1 8 #469
Merged
jsanhc
merged 30 commits into
master
from
feature/36-variable-recurring-payments-for-3-1-8
Dec 15, 2021
Merged
Feature/36 variable recurring payments for 3 1 8 #469
jsanhc
merged 30 commits into
master
from
feature/36-variable-recurring-payments-for-3-1-8
Dec 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes to VRP and Funds Conformation Issue: OpenBankingToolkit/openbanking-toolkit#45
- Fix simbols - Fix Shortcuts annotations in VRP controller interfaces Issue: OpenBankingToolkit/openbanking-toolkit#47
- Fix VRP request Mapping controllers annotation Issue: OpenBankingToolkit/openbanking-toolkit#47
Some of the Consent stuff doesn't compile, but the VRP side now compiling
* 47: vrp consent controllers - First approach to implement the consent controllers Issue: OpenBankingToolkit/openbanking-toolkit#47 * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments
* 47: vrp consent controllers - rebase - First approach to implement the consent controllers Issue: OpenBankingToolkit/openbanking-toolkit#47 * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * 47: vrp payment consent controller - Updated discovery configuration - Updated resource link service to introduce the vrp links - Other improvements for vrp consent Issue: OpenBankingToolkit/openbanking-toolkit#47
Hand over to Jorge! Issue: OpenBankingToolkit/openbanking-toolkit#48
…on-of-VRP-payment-controller 48: Develop DomesticVrpApi and controllers
* 47: vrp consent controllers - rebase - First approach to implement the consent controllers Issue: OpenBankingToolkit/openbanking-toolkit#47 * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments * Added store IT test
- Added Integration tests for VRP payment consent - Few fixes Issue: OpenBankingToolkit/openbanking-toolkit#47
- Added implementation to consent details and decision to present data on Bank UI - Added implementation consent operations (Post, Get, delete) - Added Integration tests - Set the proper snapshot dependencies for development iteration on branch 36 (must be updated before merge on master) Issue: OpenBankingToolkit/openbanking-toolkit#47
In accord with this spec; https://openbankinguk.github.io/read-write-api-site3/v3.1.8/resources-and-data-models/vrp/domestic-vrps.html#post-domestic-vrps Each VRP request need to test that the initiation and risk objects match those that were provided when the consent was created. Issue: OpenBankingToolkit/openbanking-toolkit#36
…ecurring-payments-for-3-1-8-jamie 36: Add filters to test vrp Payments risk and initiation
Add filters to ensure that Creditor is provided in the request if it doesn't exist in the consent Issue: OpenBankingToolkit/openbanking-toolkit#36
…ecurring-payments-for-3-1-8-jamie 36: Further VRP request filters
BohoCode
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VRP payment
APISIssue:Variable Recurring Payments (VRPs) for v3.1.8 openbanking-toolkit#36