Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/36 variable recurring payments for 3 1 8 #469

Merged
merged 30 commits into from
Dec 15, 2021

Conversation

jsanhc
Copy link
Contributor

@jsanhc jsanhc commented Dec 15, 2021

BohoCode and others added 28 commits November 18, 2021 16:08
- Fix simbols
- Fix Shortcuts annotations in VRP controller interfaces
Issue: OpenBankingToolkit/openbanking-toolkit#47
- Fix VRP request Mapping controllers annotation
Issue: OpenBankingToolkit/openbanking-toolkit#47
Some of the Consent stuff doesn't compile, but the VRP side now
compiling
* 47: vrp consent controllers
- First approach to implement the consent controllers
Issue: OpenBankingToolkit/openbanking-toolkit#47

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments
* 47: vrp consent controllers
- rebase
- First approach to implement the consent controllers
Issue: OpenBankingToolkit/openbanking-toolkit#47

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* 47: vrp payment consent controller
- Updated discovery configuration
- Updated resource link service to introduce the vrp links
- Other improvements for vrp consent
Issue: OpenBankingToolkit/openbanking-toolkit#47
…on-of-VRP-payment-controller

48: Develop DomesticVrpApi and controllers
* 47: vrp consent controllers
- rebase
- First approach to implement the consent controllers
Issue: OpenBankingToolkit/openbanking-toolkit#47

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Added store IT test
- Added Integration tests for VRP payment consent
- Few fixes
Issue: OpenBankingToolkit/openbanking-toolkit#47
- Added implementation to consent details and decision to present data on Bank UI
- Added implementation consent operations (Post, Get, delete)
- Added Integration tests
- Set the proper snapshot dependencies for development iteration on branch 36 (must be updated before merge on master)
Issue: OpenBankingToolkit/openbanking-toolkit#47
In accord with this spec;
https://openbankinguk.github.io/read-write-api-site3/v3.1.8/resources-and-data-models/vrp/domestic-vrps.html#post-domestic-vrps

Each VRP request need to test that the initiation and risk objects match
those that were provided when the consent was created.

Issue: OpenBankingToolkit/openbanking-toolkit#36
…ecurring-payments-for-3-1-8-jamie

36: Add filters to test vrp Payments risk and initiation
Add filters to ensure that Creditor is provided in the request if it
doesn't exist in the consent

Issue: OpenBankingToolkit/openbanking-toolkit#36
…ecurring-payments-for-3-1-8-jamie

36: Further VRP request filters
@jsanhc jsanhc requested a review from BohoCode December 15, 2021 12:18
@jsanhc jsanhc self-assigned this Dec 15, 2021
@jsanhc jsanhc merged commit ef3db5f into master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants