Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate VRP datamodels and controllers. #45

Closed
BohoCode opened this issue Nov 17, 2021 · 1 comment
Closed

Generate VRP datamodels and controllers. #45

BohoCode opened this issue Nov 17, 2021 · 1 comment
Assignees

Comments

@BohoCode
Copy link
Contributor

Generate VRP datamodels and controllers.

Using the latest swagger files, generate data classes (models) and controllers.
https://github.com/OpenBankingUK/read-write-api-specs/blob/v3.1.8r5/dist/openapi/vrp-openapi.yaml

Originally posted by @BohoCode in #36 (comment)

BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 17, 2021
Some fixes have been added since Matt's generation in issue #36

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 17, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 18, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 18, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 18, 2021
Some fixes have been added since Matt's generation in issue #36

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 18, 2021
Some fixes have been added since Matt's generation in issue #36

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 18, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-datamodel that referenced this issue Nov 18, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-parent that referenced this issue Nov 18, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-common that referenced this issue Nov 18, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-clients that referenced this issue Nov 18, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-jwkms that referenced this issue Nov 19, 2021
- Also add some extra logging regarding the application making calls to
  the jwkms

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-auth that referenced this issue Nov 19, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-tpp that referenced this issue Nov 19, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-parent that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-common that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-clients that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-jwkms that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-auth that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-tpp that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-directory that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-analytics that referenced this issue Nov 25, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
BohoCode added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Nov 26, 2021
BohoCode added a commit to OpenBankingToolkit/openbanking-uk-extensions that referenced this issue Nov 26, 2021
OBFundsConfirmationConsentResponse1Data uses OBExternalRequestStatus1Code rather than the StatusEnum
defined within the class.

Issue: OpenBankingToolkit/openbanking-toolkit#45
jsanhc pushed a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Nov 26, 2021
jsanhc added a commit to OpenBankingToolkit/openbanking-common that referenced this issue Nov 26, 2021
- Added the obReference to manage enable/disable endpoints for VRP apis
Issue: OpenBankingToolkit/openbanking-toolkit#45
jsanhc added a commit to OpenBankingToolkit/openbanking-aspsp that referenced this issue Dec 15, 2021
* 45: Add VRP generated API and Controllers

Issue: OpenBankingToolkit/openbanking-toolkit#45

* commit before rebase master

* 45: Use latest uk-datamodel with 3.1.8r5 swagger models

Some changes to VRP and Funds Conformation

Issue: OpenBankingToolkit/openbanking-toolkit#45

* Release candidate: prepare release 1.5.6

* Release candidate: prepare for next development iteration

* after rebase master

* 47: vrp consent controllers
- Fix simbols
- Fix Shortcuts annotations in VRP controller interfaces
Issue: OpenBankingToolkit/openbanking-toolkit#47

* 47: VRP consent controllers
- Fix VRP request Mapping controllers annotation
Issue: OpenBankingToolkit/openbanking-toolkit#47

* Intermediate checkin with new 3.1.9r3 datamodels (#462)

Some of the Consent stuff doesn't compile, but the VRP side now
compiling

* 47: vrp consent controllers (#463)

* 47: vrp consent controllers
- First approach to implement the consent controllers
Issue: OpenBankingToolkit/openbanking-toolkit#47

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* 47: vrp payment consent controller (#464)

* 47: vrp consent controllers
- rebase
- First approach to implement the consent controllers
Issue: OpenBankingToolkit/openbanking-toolkit#47

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* 47: vrp payment consent controller
- Updated discovery configuration
- Updated resource link service to introduce the vrp links
- Other improvements for vrp consent
Issue: OpenBankingToolkit/openbanking-toolkit#47

* 48: Develop DomesticVrpApi and controllers

Hand over to Jorge!

Issue: OpenBankingToolkit/openbanking-toolkit#48

* Issue/47 implementation of vrp payment consent controller (#466)

* 47: vrp consent controllers
- rebase
- First approach to implement the consent controllers
Issue: OpenBankingToolkit/openbanking-toolkit#47

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Delete uk-datamodel snapshot to use the parent snapshot in the development iteration of VRP payments

* Added store IT test

* 36-47: VRP payment consent controller
- Added Integration tests for VRP payment consent
- Few fixes
Issue: OpenBankingToolkit/openbanking-toolkit#47

* 36-47: VRP consent controller flow
- Added implementation to consent details and decision to present data on Bank UI
- Added implementation consent operations (Post, Get, delete)
- Added Integration tests
- Set the proper snapshot dependencies for development iteration on branch 36 (must be updated before merge on master)
Issue: OpenBankingToolkit/openbanking-toolkit#47

* VRP Funds confirmation

* Fix Domestic consent controller constructor to delete unused service

* Fix integration tests for VRP funds confirmation

* 36: Add filters to test vrp Payments risk and initiation

In accord with this spec;
https://openbankinguk.github.io/read-write-api-site3/v3.1.8/resources-and-data-models/vrp/domestic-vrps.html#post-domestic-vrps

Each VRP request need to test that the initiation and risk objects match
those that were provided when the consent was created.

Issue: OpenBankingToolkit/openbanking-toolkit#36

* 36: Further VRP request filters

Add filters to ensure that Creditor is provided in the request if it
doesn't exist in the consent

Issue: OpenBankingToolkit/openbanking-toolkit#36

* 36-48: VRP payment controller validations
Issue: OpenBankingToolkit/openbanking-toolkit#48

* Vrp payment submission controller and integration tests

* vrp payment contrller gateway server implementations

* Fix node version github workflow to build and tests the UIs

* Update version to 1.6.0

* Fix npm tests for VRP payment component

Co-authored-by: JamieB <jamie.bowen@forgerock.com>
Co-authored-by: Jamie Bowen <jpublic@chantrycottage.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants