Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AeroDyn cleanup #863

Merged
merged 10 commits into from
Oct 21, 2021
Merged

AeroDyn cleanup #863

merged 10 commits into from
Oct 21, 2021

Conversation

bjonkman
Copy link
Contributor

This code

  • addresses some potentially uninitialized variables in AeroDyn (caught by Intel Inspector),
  • adds some more error handling,
  • replaces syntax that gfortran may not like (based on past experience: old-NWTC/NWTC_Library@976d9bd),
  • fixes some typos in the documentation, and
  • updates comments in the example airfoil polar files to indicate new UA parameters that can be included

Related issue, if one exists
We should check if this helps with #841

Impacted areas of the software
docs, AeroDyn, AeroDyn driver

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #863 (bbb38dd) into dev (3fd75f6) will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #863   +/-   ##
=======================================
  Coverage   11.28%   11.29%           
=======================================
  Files         211      211           
  Lines      310488   310557   +69     
  Branches   181011   181045   +34     
=======================================
+ Hits        35054    35068   +14     
- Misses     231363   231395   +32     
- Partials    44071    44094   +23     
Flag Coverage Δ
regtests 11.18% <20.00%> (+<0.01%) ⬆️
unittests 2.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/aerodyn/src/AeroDyn_IO.f90 27.02% <0.00%> (-0.13%) ⬇️
modules/aerodyn/src/BEMT.f90 32.10% <0.00%> (-0.12%) ⬇️
modules/aerodyn/src/FVW.f90 29.57% <0.00%> (-0.08%) ⬇️
modules/nwtc-library/src/ModMesh.f90 16.61% <ø> (ø)
modules/aerodyn/src/AeroDyn_Driver_Subs.f90 29.74% <11.76%> (-0.31%) ⬇️
modules/nwtc-library/src/NWTC_IO.f90 26.44% <26.19%> (+0.01%) ⬆️
modules/aerodyn/src/AeroDyn.f90 27.11% <50.00%> (+0.04%) ⬆️
modules/aerodyn/src/AirfoilInfo.f90 28.77% <50.00%> (-0.17%) ⬇️
modules/aerodyn/src/AeroDyn_Driver.f90 78.72% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7a714...bbb38dd. Read the comment docs.

@bjonkman bjonkman mentioned this pull request Oct 18, 2021
@ebranlard ebranlard self-requested a review October 21, 2021 18:20
Copy link
Contributor

@ebranlard ebranlard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes looks good to me and might fix the issues with the AD reg tests failing at times. Thanks for doing that!

@rafmudaf
Copy link
Collaborator

It all looks good to me, as well. Thanks for trying to track down the problem in #841. Let me know when you're ready to merge this pull request.

@rafmudaf rafmudaf self-assigned this Oct 21, 2021
@bjonkman
Copy link
Contributor Author

bjonkman commented Oct 21, 2021

You can merge it now. If I decide to dig into this some more, I'll open another PR.

@rafmudaf rafmudaf merged commit 0789ac2 into OpenFAST:dev Oct 21, 2021
@bjonkman
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants