Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD15: add nodal outputs for VUnd{xyz}i in global coords #917

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented Nov 11, 2021

This PR is NOT ready for merging (more channel requests)

Feature or improvement description
Three new nodal outputs are added to AD15 for the undisturbed wind velocity at each blade node:

  • VUndxi Undisturbed wind velocity at blade node in global X
  • VUndyi Undisturbed wind velocity at blade node in global Y
  • VUndzi Undisturbed wind velocity at blade node in global Z

These are particularly useful in checking the inflow into a blade on an OpenFAST turbine in a CFD coupled or FAST.Farm simulation. This feature was requested by @kshaler.

Example of data for the VUndxi channel for blade 1 (from the 5MW_Land_DLL_WTurb regression test case)
Screen Shot 2021-11-11 at 3 43 59 PM

TODO

  • convert channel doc pdf to .rst and update
  • add blade nodal channels (auto generated sets):
    • induced velocity in global
    • disturbed wind in global
  • regular outputs for (9 node ones):
    • all the above
    • VUndxi etc.

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these outputs looks reasonable. If possible, it would also make sense to add the equivalent outputs for the tower (TwNβVUndxi, etc.) and for the disturbed wind at blade nodes (BαNβVDisxi, etc.). Also, the list of AeroDyn outputs in the documentation should be changed accordingly: https://openfast.readthedocs.io/en/main/_images/ad_output_channel.pdf (I have the Word version of this).

@ebranlard
Copy link
Contributor

I would add potentially the induced velocity as well :)

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #917 (9e002f8) into dev (a4d62ac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #917      +/-   ##
==========================================
- Coverage   11.17%   11.17%   -0.01%     
==========================================
  Files         211      211              
  Lines      310636   310648      +12     
  Branches   181308   181320      +12     
==========================================
  Hits        34722    34722              
- Misses     231795   231807      +12     
  Partials    44119    44119              
Flag Coverage Δ
regtests 11.06% <0.00%> (-0.01%) ⬇️
unittests 2.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/aerodyn/src/AeroDyn_AllBldNdOuts_IO.f90 9.57% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d62ac...9e002f8. Read the comment docs.

@ebranlard
Copy link
Contributor

ebranlard commented Feb 15, 2022

I would suggest to descope and merge this as it is :)

@andrew-platt
Copy link
Collaborator Author

Posted issue #1004 for the remaining items that were never completed. De-scoping this to what is thus far completed and merging (this backlog is ridiculous... mostly my fault though).

@andrew-platt andrew-platt merged commit d0d94fd into OpenFAST:dev Feb 17, 2022
@rafmudaf rafmudaf mentioned this pull request Mar 2, 2022
11 tasks
@andrew-platt andrew-platt deleted the f/AD_VUnd_global_forPR branch June 30, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants