Bugfix/UnexpectedCharacters #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused var deliveryState in MissionProcessorDeliverMission.cs
…Perpetuum/PerpetuumServer into bugfix/UnexpectedCharacters
Urglefloggah666
requested review from
Junelicious,
VisualTunic488 and
Sellafield
- project is for .NET Framework, not .NET Core; - changed the path for artifacts to a relative one; - build projects after a push and pull request; - build artifacts after a push.
|
We need to merge this pull request into the main branch to solve problems with characters in the wrong encoding. |
Sellafield
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve the issue with unexpected characters during a compile of the solution for several files.
this seems to have been caused by the files in question being "UTF-16 LE" encoded, changed to UTF-8 encoding and tested.
also added an artifact upload to the automatic compile action based on a friend's, gitstua, suggestion for github actions.
Iggs removed one variable to that was causing a warning during build too.