Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All_Of Identifier Not Found #193

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Dec 14, 2021

Context:
Attempting to compile the pennylane-lightning with MSVC2022, JacobianProd is failed to complied. The compiler cites C3861 with the description that error C3861: 'all_of': identifier not found. This PR addresses this issue by adding the header algorithm.

Related GitHub Issues:
Compilation on Windows fails (#192)

maliasadi and others added 3 commits December 9, 2021 11:05
* Replace complex128 by complex64

* Update

* Update test_apply.py

* Add C64 support to adjoint_jacobian

* Update _serialize

* Add Complex64 full support

* Update

* Update test_comparison

* Update formatting

* Update vjp tests

* Update test_comparison

* Update CHANGELOG

Co-authored-by: antalszava <antalszava@gmail.com>
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@maliasadi maliasadi requested a review from mlxd December 14, 2021 17:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   368 tests ±0     368 ✔️ ±0  0 💤 ±0  0 ±0 
2 205 runs  ±0  2 205 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dc5e7bf. ± Comparison against base commit 364cfe4.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #193 (206fce9) into master (c739f7b) will not change coverage.
The diff coverage is n/a.

❗ Current head 206fce9 differs from pull request most recent head dc5e7bf. Consider uploading reports for the commit dc5e7bf to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files           4        4           
  Lines         278      278           
=======================================
  Hits          264      264           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c739f7b...dc5e7bf. Read the comment docs.

@mlxd mlxd force-pushed the lightning_fix_allof_not_found branch from 206fce9 to dc5e7bf Compare December 15, 2021 09:49
@mlxd
Copy link
Member

mlxd commented Dec 15, 2021

I hard reset to the algorithm header commit. We do not want master to be merged here as it is to match up with the v0.20.0 tagged release.

@mlxd mlxd changed the base branch from master to v0.20.1-rc0 December 15, 2021 09:58
@mlxd mlxd merged commit 10c622f into v0.20.1-rc0 Dec 15, 2021
@mlxd mlxd deleted the lightning_fix_allof_not_found branch December 15, 2021 09:59
mlxd added a commit that referenced this pull request Dec 15, 2021
* Release v0.20.0-rc0

* Build RC wheels for W.X.Y-rcZ branches

* Add additional branch name matching option to CI

* Add regex action step for RC builds

* Modify yaml

* Modify yaml again

* Finalize 0.20.0

* Fix empty wheel builder

* Update test_serialize

* Fix failed tests

* Update CHANGELOG

* All_Of Identifier Not Found (#193)

* Add np.complex64 support in PL-Lightning (#177)

* Replace complex128 by complex64

* Update

* Update test_apply.py

* Add C64 support to adjoint_jacobian

* Update _serialize

* Add Complex64 full support

* Update

* Update test_comparison

* Update formatting

* Update vjp tests

* Update test_comparison

* Update CHANGELOG

Co-authored-by: antalszava <antalszava@gmail.com>

* Update header.html

* Add algorithm header

Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>

* Update release tag

* Update changelog

* Fix no-binary tests

* Update CHANGELOG.md

Co-authored-by: Ali Asadi <ali@xanadu.ai>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
mlxd added a commit that referenced this pull request Jan 7, 2022
* Release v0.20.0-rc0

* Build RC wheels for W.X.Y-rcZ branches

* Add additional branch name matching option to CI

* Add regex action step for RC builds

* Modify yaml

* Modify yaml again

* Finalize 0.20.0

* Fix empty wheel builder

* Update test_serialize

* Fix failed tests

* Update CHANGELOG

* All_Of Identifier Not Found (#193)

* Add np.complex64 support in PL-Lightning (#177)

* Replace complex128 by complex64

* Update

* Update test_apply.py

* Add C64 support to adjoint_jacobian

* Update _serialize

* Add Complex64 full support

* Update

* Update test_comparison

* Update formatting

* Update vjp tests

* Update test_comparison

* Update CHANGELOG

Co-authored-by: antalszava <antalszava@gmail.com>

* Update header.html

* Add algorithm header

Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>

* Update release tag

* Update changelog

* Fix no-binary tests

* Update CHANGELOG.md

* Added CY kernel to prevent bpass decomposition failure

* Update changelog

* Bump version

Co-authored-by: Ali Asadi <ali@xanadu.ai>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants