Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.20.1 merge #198

Merged
merged 19 commits into from
Dec 15, 2021
Merged

V0.20.1 merge #198

merged 19 commits into from
Dec 15, 2021

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Dec 15, 2021

Context: Adds fixes from v0.20.1

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

mlxd and others added 18 commits December 8, 2021 11:32
* Add np.complex64 support in PL-Lightning (#177)

* Replace complex128 by complex64

* Update

* Update test_apply.py

* Add C64 support to adjoint_jacobian

* Update _serialize

* Add Complex64 full support

* Update

* Update test_comparison

* Update formatting

* Update vjp tests

* Update test_comparison

* Update CHANGELOG

Co-authored-by: antalszava <antalszava@gmail.com>

* Update header.html

* Add algorithm header

Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: Josh Izaac <josh146@gmail.com>
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #198 (8200813) into master (4145566) will increase coverage by 4.67%.
The diff coverage is n/a.

❗ Current head 8200813 differs from pull request most recent head 0bf28cc. Consider uploading reports for the commit 0bf28cc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   94.96%   99.64%   +4.67%     
==========================================
  Files           4        4              
  Lines         278      278              
==========================================
+ Hits          264      277      +13     
+ Misses         14        1      -13     
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <ø> (ø)
pennylane_lightning/_serialize.py 100.00% <0.00%> (+1.28%) ⬆️
pennylane_lightning/lightning_qubit.py 99.48% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4145566...0bf28cc. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021

Test Report (C++) on Ubuntu

0 files   -        1  0 suites   - 1   0s ⏱️ ±0s
0 tests  -    378  0 ✔️  -    378  0 💤 ±0  0 ±0 
0 runs   - 2 233  0 ✔️  - 2 233  0 💤 ±0  0 ±0 

Results for commit 0bf28cc. ± Comparison against base commit 772bf0e.

This pull request removes 378 tests.
runner.global ‑ AdjointJacobian::AdjointJacobian - double/AdjointJacobian
runner.global ‑ AdjointJacobian::AdjointJacobian - double/AdjointJacobian<TestType> {}
runner.global ‑ AdjointJacobian::AdjointJacobian - float/AdjointJacobian
runner.global ‑ AdjointJacobian::AdjointJacobian - float/AdjointJacobian<TestType> {}
runner.global ‑ AdjointJacobian::adjointJacobian Decomposed Rot gate, non computational basis state
runner.global ‑ AdjointJacobian::adjointJacobian Mixed Ops, Obs and TParams
runner.global ‑ AdjointJacobian::adjointJacobian Op=Mixed, Obs=[XXX]
runner.global ‑ AdjointJacobian::adjointJacobian Op=RX, Obs=Z
runner.global ‑ AdjointJacobian::adjointJacobian Op=RX, Obs=[Z,Z]
runner.global ‑ AdjointJacobian::adjointJacobian Op=RY, Obs=X
…

♻️ This comment has been updated with latest results.

@mlxd mlxd requested review from maliasadi, chaeyeunpark and AmintorDusko and removed request for maliasadi December 15, 2021 14:27
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlxd!

tests/test_serialize.py Show resolved Hide resolved
pennylane_lightning/_serialize.py Outdated Show resolved Hide resolved
pennylane_lightning/_serialize.py Outdated Show resolved Hide resolved
pennylane_lightning/lightning_qubit.py Outdated Show resolved Hide resolved
pennylane_lightning/lightning_qubit.py Outdated Show resolved Hide resolved
pennylane_lightning/lightning_qubit.py Outdated Show resolved Hide resolved
pennylane_lightning/lightning_qubit.py Outdated Show resolved Hide resolved
tests/test_serialize.py Show resolved Hide resolved
tests/test_apply.py Show resolved Hide resolved
@AmintorDusko
Copy link
Contributor

AmintorDusko commented Dec 15, 2021

Very nice PR! Very good work! This PR is approved.

@mlxd mlxd merged commit 5b65f2a into master Dec 15, 2021
@mlxd mlxd deleted the v0.20.1_merge branch December 15, 2021 15:42
@mlxd mlxd restored the v0.20.1_merge branch January 7, 2022 12:54
@mlxd mlxd deleted the v0.20.1_merge branch January 7, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants