Fix the LK+Windows and Catalyst+Lightning latest/latest failures #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the decomposition of ctrl(LQ) and hardcode of expanded controlled matrices in the IR. LightningKokkos zero-qubit device initialization is not supported on Windows.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
==========================================
- Coverage 95.57% 95.10% -0.47%
==========================================
Files 109 92 -17
Lines 15694 13796 -1898
==========================================
- Hits 14999 13121 -1878
+ Misses 695 675 -20 ☔ View full report in Codecov by Sentry. |
maliasadi
changed the title
pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Show resolved
Hide resolved
vincentmr
reviewed
Jun 14, 2024
dime10
reviewed
Jun 14, 2024
dime10
reviewed
Jun 14, 2024
AmintorDusko
approved these changes
Jun 14, 2024
vincentmr
reviewed
Jun 14, 2024
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
vincentmr
approved these changes
Jun 14, 2024
multiphaseCFD
approved these changes
Jun 14, 2024
maliasadi
pushed a commit
that referenced
this pull request
Jun 18, 2024
ControlledQubitUnitary is present in the Python device but not the TOML (since #758 removed it from native gates), added it back to the decomposition gates since it can be implemented in its alternate form of C(QubitUnitary). Required for PennyLaneAI/catalyst#785 --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
dime10
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Jun 18, 2024
This PR aims to remove obsolete TOML related code and also resolve incompatibilities with the latest lightning device versions. - The verifier is relaxed to only test agreement of basic gates (no adjoint/control) between the toml and python device spec. - This is needed to resolve the overlapping gate issue introduced by PennyLaneAI/pennylane-lightning#743 - and also allows removing the patch for Lightning Kokkos that exists solely to satisfy the verifier. - The obsolete toml files in the catalyst repo for lightning devices is also removed. - MCMs are marked as un-invertible and un-controllable, since they are non-unitary. Requires: PennyLaneAI/pennylane-lightning#758 [sc-65114]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
ControlledQubitUnitaryin favour ofC(QubitUnitary)from the list of supported operations and the device toml file. Thestopping_conditionmethod guarantees the consistency of decompositions. This change also reduces the size of the generated IR and impact the performance of Catalyst for the computation ofC(QubitUnitrary)as this controlled gate is currently decomposed toQubitUnitary, hardcoding the expanded controlled-unitary-matrix into the IR.lightning.kokkoswith zero-qubit on Windows. Allocating 0-size Kokkos vectors not supported on Windows. Required to Pass LK+Windows CI.