Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lightning_kokkos.toml #767

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Update lightning_kokkos.toml #767

merged 2 commits into from
Jun 18, 2024

Conversation

dime10
Copy link
Contributor

@dime10 dime10 commented Jun 18, 2024

ControlledQubitUnitary is present in the Python device but not the TOML (since #758 removed it from native gates), added it back to the decomposition gates since it can be implemented in its alternate form of C(QubitUnitary).

Required for PennyLaneAI/catalyst#785

ControlledQubitUnitary is present in the Python device but not the TOML,
added to the decomposition gates since it can be implemented in its alternate
form of C(QubitUnitary).
@dime10 dime10 requested a review from maliasadi June 18, 2024 18:21
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.62%. Comparing base (9598b09) to head (4b3e36a).
Report is 93 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9598b09) and HEAD (4b3e36a). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9598b09) HEAD (4b3e36a)
9 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #767       +/-   ##
===========================================
- Coverage   94.24%   27.62%   -66.62%     
===========================================
  Files          92       17       -75     
  Lines       13778     1904    -11874     
===========================================
- Hits        12985      526    -12459     
- Misses        793     1378      +585     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dime10 dime10 requested a review from vincentmr June 18, 2024 18:29
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers @dime10 .

@maliasadi maliasadi merged commit 476cac2 into master Jun 18, 2024
61 of 62 checks passed
@maliasadi maliasadi deleted the dime10-patch-2 branch June 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants