Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Statetensor to TensorNet #759

Merged
merged 9 commits into from
Jun 11, 2024
Merged

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Jun 10, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

It will be more clear to type of MPS and Exact TN objects passed to obstncuda and measurementtncuda class since the object is simply a graph.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD marked this pull request as ready for review June 10, 2024 21:13
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (547de08) to head (8b2e118).
Report is 85 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   95.22%   98.49%   +3.26%     
==========================================
  Files         120      107      -13     
  Lines       17462    15504    -1958     
==========================================
- Hits        16629    15270    -1359     
+ Misses        833      234     -599     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

.github/CHANGELOG.md Outdated Show resolved Hide resolved
multiphaseCFD and others added 6 commits June 10, 2024 22:41
Please complete the following checklist when submitting a PR:

- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [x] Ensure that the test suite passes, by running `make test`.

- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [x] Ensure that code is properly formatted by running `make format`.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

------------------------------------------------------------------------------------------------------------

**Context:**
MCM tests are slow and dominate the CI run time. New tests have been
incorporated as new features came in without rationalizing the test
suite as a whole. There are redundant or overly parametrized tests as a
results.

**Description of the Change:**
Combine a bunch of tests into `test_simple_dynamic_circuit` which tests
all possible measurements are handle correctly by `dynamic_one_shot`
post-processing. This needs not be parametrized over `reset` since it
does not show up in post-processing.

Combine some tests into `test_multiple_measurements_and_reset` which
checks that multiple measurements are handle correctly and that `reset`
is properly applied while getting to the final state.

Combine all composite MCM measurements in `test_composite_mcms`.

`test_counts_return_type` remains as is.

**Benefits:**
Faster CI.

**Possible Drawbacks:**

**Related GitHub Issues:**
[sc-65255]

---------

Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@multiphaseCFD multiphaseCFD merged commit f57df46 into master Jun 11, 2024
92 checks passed
@multiphaseCFD multiphaseCFD deleted the refactor_state_tensor_name branch June 11, 2024 12:09
multiphaseCFD added a commit that referenced this pull request Jun 11, 2024
Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [x] Ensure that the test suite passes, by running `make test`.

- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [x] Ensure that code is properly formatted by running `make format`.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

------------------------------------------------------------------------------------------------------------

**Context:**

It will be more clear to type of `MPS` and `Exact TN` objects passed to
`obstncuda` and `measurementtncuda` class since the object is simply a
graph.

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants