Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd_real_cluster: remove cd to specific dir #2689

Merged
merged 2 commits into from
Dec 19, 2023
Merged

pd_real_cluster: remove cd to specific dir #2689

merged 2 commits into from
Dec 19, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Dec 19, 2023

after tikv/pd#7567 merged we can remove cd operator

@HuSharp
remove cd
7a2644a 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

  • The pull request removes the cd operator from a shell script in the pd directory.

Potential problems:

  • None apparent

Fixing suggestions:

  • None necessary. The changes are straightforward and correct.

@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 19, 2023

cc @JmPotato

@HuSharp
replace name
3db6399 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

The pull request removes the cd operator and replaces it with make test-real-cluster in the PD Real Cluster Check section of the pull_integration_realcluster_test.groovy file.

Potential problems:

There are no potential problems with this pull request.

Fixing suggestions:

No fixing suggestions are needed.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 19, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 02:31:21.525480721 +0000 UTC m=+928172.562707644: ☑️ agreed by JmPotato.

@JmPotato JmPotato mentioned this pull request Dec 19, 2023
Merged
purelind
purelind approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot merged commit 387e9e5 into PingCAP-QE:main Dec 19, 2023
1 of 2 checks passed
@HuSharp HuSharp deleted the remove_cd branch December 19, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@purelind purelind purelind approved these changes

@lijie0123 lijie0123 Awaiting requested review from lijie0123

Assignees

@JmPotato JmPotato

@purelind purelind

Labels
approved area/jenkins-pipelines lgtm size/XS
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuSharp @JmPotato @purelind