Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests, Makefile: rename the test from realtiup to realcluster #7573

Merged
merged 1 commit into from
Dec 20, 2023
Merged

tests, Makefile: rename the test from realtiup to realcluster #7573

merged 1 commit into from
Dec 20, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7298.

What is changed and how does it work?

Rename the real-cluster test to a more general naming.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/testing CI testing. require-LGT1 Indicates that the PR requires an LGTM. labels Dec 19, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Merging #7573 (0759e31) into master (3b2e611) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 0759e31 differs from pull request most recent head f8829a4. Consider uploading reports for the commit f8829a4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7573      +/-   ##
==========================================
- Coverage   74.80%   74.78%   -0.03%     
==========================================
  Files         457      457              
  Lines       50392    50341      -51     
==========================================
- Hits        37694    37645      -49     
+ Misses       9370     9365       -5     
- Partials     3328     3331       +3
Flag Coverage Δ
unittests 74.78% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0759e31

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 19, 2023
@JmPotato
Copy link
Member Author

JmPotato commented Dec 19, 2023 •
edited
Loading

/hold

Wait for PingCAP-QE/ci#2689.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023
@HuSharp
Copy link
Member

HuSharp commented Dec 19, 2023

/test ?

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

@HuSharp: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Member

HuSharp commented Dec 19, 2023

/test pull-integration-realcluster-test

2 similar comments
@HuSharp
Copy link
Member

HuSharp commented Dec 19, 2023

/test pull-integration-realcluster-test

@purelind
Copy link
Contributor

/test pull-integration-realcluster-test

@purelind
Copy link
Contributor

/test ?

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

@purelind: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

/test build

1 similar comment
@wuhuizuo
Copy link
Contributor

/test build

@wuhuizuo
Copy link
Contributor

/test all

@wuhuizuo
Copy link
Contributor

/test pull-integration-copr-test

1 similar comment
@wuhuizuo
Copy link
Contributor

/test pull-integration-copr-test

@wuhuizuo
Copy link
Contributor

/test pull-integration-copr-test

@HuSharp
Copy link
Member

HuSharp commented Dec 20, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2023
@JmPotato
Rename the test from realtiup to realcluster
f8829a4 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f8829a4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2023
@HuSharp
Copy link
Member

HuSharp commented Dec 20, 2023

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot merged commit d98daf3 into tikv:master Dec 20, 2023
23 checks passed
@JmPotato JmPotato deleted the rename_real_cluster_test branch December 20, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@HuSharp HuSharp HuSharp approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
component/testing CI testing. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JmPotato @HuSharp @purelind @wuhuizuo @rleungx