-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add link to event page from portal #328
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
@jukent looks good but wonder if we can make it stand out more? Maybe as simple as a bigger and/or bolder and/or different-colored font? |
I've been playing around with sphinx-design (a JupyterBook dependency) and it's easy to create snazzy buttons. We already have a few buttons hanging around anyway (and can always just borrow the html from those), who doesn't love a good button? |
Great idea @dcamron ! |
For some reason I can't see the preview for this PR. Following the preview link keeps redirecting to the home page at https://projectpythia.org. |
@brian-rose Yes the same for me. I had to clone this fork and build the site locally. |
Any idea why that might be? |
@jukent I don't ... we should open a separate issue about this. But in the interest of getting this merged, the only thing I would suggest is to maybe have a different background color other than white for the Cookoff button? It would make it stand out just a bit more. |
I can do that, just don't know what color is best. I'll work on it though (I changed it to green locally just to test that I could do it as I expected). |
on the cookoff site, I went with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough. The fact that the text reads "Learn more here" should make it clear to most folks that this is a clickable link.
I think the screenshot looks good. |
If I have a moment today, I'll try opening a bare bones PR on this repo to see if the preview is still failing. |
Okay @brian-rose just merge when you're ready |
I merged, but the changes didn't get published on the portal site. There's something wrong with the actions that publish to GitHub Pages, which is affecting both the preview and the actual publication. The gh-pages branch of the repo hasn't seen any pushes in three months. |
The new link is finally visible now at https://projectpythia.org! |
This PR adds a link to the event on the main portal page. Perhaps we want to link this differently, but this was the easiest solution I found.
Eventually we may want an "events" tab in the nav bar that lists past events, events we'll be present at or give talks/tutorials, and events that we host.