Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to event page from portal #328

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Apr 7, 2023

This PR adds a link to the event on the main portal page. Perhaps we want to link this differently, but this was the easiest solution I found.

Eventually we may want an "events" tab in the nav bar that lists past events, events we'll be present at or give talks/tutorials, and events that we host.

@jukent jukent requested a review from a team April 7, 2023 20:22
@jukent jukent requested a review from a team as a code owner April 7, 2023 20:22
@jukent jukent requested review from ktyle, erogluorhan, dopplershift, anissa111 and clyne and removed request for a team and anissa111 April 7, 2023 20:22
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 0ffbeac
✅ Deployment Preview URL: https://ProjectPythia.github.io/projectpythia.github.io/_preview/328

@jukent jukent requested review from brian-rose, dcamron and mgrover1 and removed request for erogluorhan April 7, 2023 20:23
@ktyle
Copy link
Contributor

ktyle commented Apr 10, 2023

@jukent looks good but wonder if we can make it stand out more? Maybe as simple as a bigger and/or bolder and/or different-colored font?

@dcamron
Copy link
Contributor

dcamron commented Apr 10, 2023

@jukent looks good but wonder if we can make it stand out more? Maybe as simple as a bigger and/or bolder and/or different-colored font?

I've been playing around with sphinx-design (a JupyterBook dependency) and it's easy to create snazzy buttons. We already have a few buttons hanging around anyway (and can always just borrow the html from those), who doesn't love a good button?

@jukent
Copy link
Contributor Author

jukent commented Apr 10, 2023

Great idea @dcamron !

mgrover1
mgrover1 previously approved these changes Apr 11, 2023
@brian-rose
Copy link
Member

For some reason I can't see the preview for this PR. Following the preview link keeps redirecting to the home page at https://projectpythia.org.

@ktyle
Copy link
Contributor

ktyle commented Apr 12, 2023

@brian-rose Yes the same for me. I had to clone this fork and build the site locally.

@jukent
Copy link
Contributor Author

jukent commented Apr 13, 2023

Any idea why that might be?

@ktyle
Copy link
Contributor

ktyle commented Apr 13, 2023

@jukent I don't ... we should open a separate issue about this. But in the interest of getting this merged, the only thing I would suggest is to maybe have a different background color other than white for the Cookoff button? It would make it stand out just a bit more.

@jukent
Copy link
Contributor Author

jukent commented Apr 13, 2023

I can do that, just don't know what color is best. I'll work on it though (I changed it to green locally just to test that I could do it as I expected).

@dcamron
Copy link
Contributor

dcamron commented Apr 13, 2023

on the cookoff site, I went with .secondary, which should be the navbar Pythia Grey. I haven't previewed this, so I'm not sure how that might look

@jukent
Copy link
Contributor Author

jukent commented Apr 13, 2023

Screen Shot 2023-04-13 at 10 57 52 AM

I changed the button color. It stands out a bit better, but still doesn't look the best. Is it obvious that it is clickable? The curser does change when you hover over it.

Copy link
Contributor

@ktyle ktyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough. The fact that the text reads "Learn more here" should make it clear to most folks that this is a clickable link.

@brian-rose
Copy link
Member

I think the screenshot looks good.

@brian-rose
Copy link
Member

If I have a moment today, I'll try opening a bare bones PR on this repo to see if the preview is still failing.

@jukent
Copy link
Contributor Author

jukent commented Apr 13, 2023

Okay @brian-rose just merge when you're ready

@brian-rose brian-rose merged commit 2e4d1f7 into ProjectPythia:main Apr 14, 2023
@brian-rose
Copy link
Member

I merged, but the changes didn't get published on the portal site.

There's something wrong with the actions that publish to GitHub Pages, which is affecting both the preview and the actual publication. The gh-pages branch of the repo hasn't seen any pushes in three months.

@brian-rose
Copy link
Member

The new link is finally visible now at https://projectpythia.org!

dcamron added a commit that referenced this pull request Jul 12, 2023
Remove Hackathon banner now that event has ended.
@dcamron dcamron mentioned this pull request Jul 12, 2023
ktyle pushed a commit that referenced this pull request Jul 13, 2023
Remove Hackathon banner now that event has ended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants