Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new publish_dir option for deploy-book workflow #331

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Use the new publish_dir option for deploy-book workflow #331

merged 1 commit into from
Apr 17, 2023

Conversation

brian-rose
Copy link
Member

Resolves #329

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: c49e89c
✅ Deployment Preview URL: https://ProjectPythia.github.io/projectpythia.github.io/_preview/331

@brian-rose
Copy link
Member Author

This needs to be merged before we can actually test if it's working since the preview deployment workflow is running from main branch.

@brian-rose brian-rose marked this pull request as ready for review April 17, 2023 14:49
@ktyle
Copy link
Contributor

ktyle commented Apr 17, 2023

@brian-rose Great! I notice that the modification that @jukent made in #328 isn't showing up on the preview yet, though.

@brian-rose brian-rose requested a review from a team as a code owner April 17, 2023 14:49
@brian-rose brian-rose requested review from ktyle and dcamron and removed request for a team April 17, 2023 14:49
@brian-rose
Copy link
Member Author

brian-rose commented Apr 17, 2023 •
edited
Loading

@brian-rose Great! I notice that the modification that @jukent made in #328 isn't showing up on the preview yet, though.

Yeah, due to quirks in how GitHub actions work, we need to merge this first before we can test it.

The preview link is redirecting to the unmodified portal site currently.

ktyle
ktyle approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ktyle ktyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Given the importance of this change, I think we should merge ASAP.

@brian-rose
Copy link
Member Author

Great job! Given the importance of this change, I think we should merge ASAP.

Thanks, I'll merge and test right now.

@brian-rose brian-rose merged commit bdb8cc6 into ProjectPythia:main Apr 17, 2023
@brian-rose brian-rose deleted the fix-publish-path branch April 17, 2023 14:56
@brian-rose brian-rose mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktyle ktyle ktyle approved these changes

@dcamron dcamron Awaiting requested review from dcamron dcamron is a code owner automatically assigned from ProjectPythia/infrastructure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site is not publishing to GitHub Pages
2 participants
@brian-rose @ktyle