Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default returning type of 'to_cbor' to bytes #232

Merged
merged 1 commit into from
May 7, 2023

Conversation

cffls
Copy link
Collaborator

@cffls cffls commented May 7, 2023

Change the default returning type of 'to_cbor' to bytes and add 'to_cbor_hex' that returns cbor hex.

Change the default returning type of 'to_cbor' to bytes and add 'to_cbor_hex' that returns cbor hex.
@cffls cffls requested a review from nielstron May 7, 2023 17:21
@codecov-commenter
Copy link

Codecov Report

Merging #232 (2da68c0) into main (40f00fb) will increase coverage by 0.04%.
The diff coverage is 90.47%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   85.45%   85.50%   +0.04%     
==========================================
  Files          26       26              
  Lines        2957     2953       -4     
  Branches      709      707       -2     
==========================================
- Hits         2527     2525       -2     
+ Misses        318      317       -1     
+ Partials      112      111       -1     
Impacted Files Coverage Δ
pycardano/key.py 87.83% <ø> (ø)
pycardano/metadata.py 94.59% <ø> (ø)
pycardano/utils.py 94.82% <ø> (ø)
pycardano/backend/base.py 93.58% <66.66%> (ø)
pycardano/txbuilder.py 90.33% <75.00%> (ø)
pycardano/nativescript.py 98.01% <100.00%> (ø)
pycardano/plutus.py 87.60% <100.00%> (ø)
pycardano/serialization.py 85.08% <100.00%> (+0.46%) ⬆️
pycardano/transaction.py 94.09% <100.00%> (ø)

@cffls cffls added the enhancement New feature or request label May 7, 2023
@cffls cffls merged commit eaadc38 into Python-Cardano:main May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants