Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PFDA vignette not stop on error #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Mar 17, 2022

  1. Make PFDA vignette not stop on error

    Running on CentOS 7 with R 4.1.2 with fully-updated packages on 2022 March 17
    produced the following error
    ```
       --- re-building ‘faustPFDA.Rmd’ using rmarkdown
       Quitting from lines 426-439 (faustPFDA.Rmd) 
       Error: processing vignette 'faustPFDA.Rmd' failed with diagnostics:
       Downdated VtV is not positive definite
       --- failed re-building ‘faustPFDA.Rmd’
    ``` 
    
    when building vignettes on install, which blocked
    the install. To allow the Rmd to complete even with the error (and allow at least to see part of that vignette and the other two vignettes
    when installing with vignettes), I added
    `error = TRUE` as an argument to `knitr::opts_chunk$set`.
    MiguelRodo committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    1d8ed6b View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Configuration menu
    Copy the full SHA
    35f6577 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Fix modVals logical comparison length bug

    In R3.6.3, using vectors with length greater than one in the condition of an if statement merely warned and used the first element, but past verion 4.something it throws an error. 
    
    It's not entirely clear to me whether any or all would be better. Presumably any, as if there are any NAs then we would want to fix the behaviour. So that's what we went with.
    MiguelRodo authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f32a65a View commit details
    Browse the repository at this point in the history