Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc: Missing unit test for gnrc_pktbuf_replace_snip #5089

Closed
jnohlgard opened this issue Mar 16, 2016 · 4 comments · Fixed by #13333
Closed

gnrc: Missing unit test for gnrc_pktbuf_replace_snip #5089

jnohlgard opened this issue Mar 16, 2016 · 4 comments · Fixed by #13333
Assignees
@miri64
Labels
Area: tests Area: tests and testing framework Type: new feature The issue requests / The PR implemements a new feature for RIOT

Comments

@jnohlgard
Copy link
Member

Function was added by #5029
@jnohlgard jnohlgard added Area: tests Area: tests and testing framework Feature Request labels Mar 16, 2016
@miri64 miri64 added this to the Release 2016.10 milestone Oct 18, 2016
@miri64 miri64 self-assigned this Oct 18, 2016
@miri64
Copy link
Member

miri64 commented Oct 31, 2016

Needs to be postponed again :(

@miri64 miri64 modified the milestones: Release 2017.01, Release 2016.10 Oct 31, 2016
@PeterKietzmann PeterKietzmann modified the milestones: Release 2017.01, Release 2017.04 Jan 26, 2017
@miri64 miri64 added Type: new feature The issue requests / The PR implemements a new feature for RIOT and removed Feature Request labels Sep 30, 2018
@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale
Copy link

stale bot commented Feb 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Feb 11, 2020
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Feb 11, 2020
miri64 added a commit to miri64/RIOT that referenced this issue Feb 11, 2020
@miri64
gnrc_pktbuf: remove gnrc_pktbuf_replace_snip()
370e73e 
The function is unused and unneeded since 69d9ecc and
RIOT-OS#5089 calls to provide unittests.
@miri64 miri64 mentioned this issue Feb 11, 2020
Merged
@miri64
Copy link
Member

miri64 commented Feb 11, 2020

#13333 deprecates this function, as it is not needed by 6LoWPAN anymore after some major rework.

miri64 added a commit to miri64/RIOT that referenced this issue Feb 11, 2020
@miri64
gnrc_pktbuf: deprecate gnrc_pktbuf_replace_snip()
e94aa40 
The function is unused and unneeded since 69d9ecc and
RIOT-OS#5089 calls to provide unittests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miri64 miri64

Labels
Area: tests Area: tests and testing framework Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gnrc_pktbuf: deprecate gnrc_pktbuf_replace_snip() miri64/RIOT
4 participants
@jnohlgard @miri64 @aabadie @PeterKietzmann