gnrc_pktbuf: deprecate gnrc_pktbuf_replace_snip() #13333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: network
miri64
changed the title
The function is unused and unneeded since 69d9ecc and RIOT-OS#5089 calls to provide unittests.
miri64
force-pushed
the
gnrc_pktbuf/cleanup/replace
branch
from
370e73e
to
e94aa40
Compare
benpicco
approved these changes
Feb 11, 2020
|
Even if, with the deprecation note they still have 8 more month to remove their usage ;-). |
leandrolanzieri
added
Impact: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The function is unused and unneeded since #9484 and #5089 calls to provide unittests.
Testing procedure
git grep "gnrc_pktbuf_replace_snip"should only show the function declaration and definition.
With
the function appears in
doc/doxygen/html/deprecated.html.Issues/PRs references
Resolves #5089