Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

periph/gpio: Add open drain as a push-pull option #4750

Closed
wants to merge 2 commits into from
Closed

periph/gpio: Add open drain as a push-pull option #4750

wants to merge 2 commits into from

Conversation

jnohlgard
Copy link
Member

Added GPIO_OPEN_DRAIN for configuring outputs as open drain. This relates to the discussion in #4428 and I also needed to configure an open drain output.

Also included is a change for the kinetis family to add open drain support.

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Area: drivers Area: Device drivers labels Feb 5, 2016
@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 5, 2016
PeterKietzmann referenced this pull request in ReneHerthel/RIOT Feb 5, 2016
@ReneHerthel
stm32l1/i2c: Using GPIO API now, minor fixes
666158c
@haukepetersen
Copy link
Contributor

see also #4472. By now, I would opt for making the push-pull configuration available by defining a direction option GPIO_DIR_OUT_OD instead of a pull resistor option.

This was referenced Feb 16, 2016
Closed
Closed
@jnohlgard
Copy link
Member Author

Closing in favour of #4862

@jnohlgard jnohlgard closed this Mar 2, 2016
@jnohlgard jnohlgard deleted the pr/gpio-open-drain branch April 6, 2017 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnohlgard @haukepetersen