stm32l1 allow open drain #4854
Closed
stm32l1 allow open drain #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 19, 2016 18:24
Some peripherals (e.g. i2c) must be configured in open drain. Otherwise weird behaviour appears such as voltages half way up or down. This adds support to configure Open-Drain GPIO from the standard API.
Otherwise the voltages do not go all the way up or down.
OlegHahm
added
Type: enhancement
haukepetersen
added
the
CI: ready for build
|
I am working at a solution for #4472 as we speak (probably get it done today, but testing will take a while), so I would say we merge this first so at least the I2C for the l1 is fixed for now. code looks valid -> untested ACK once Travis is green. |
|
I didn't see there was discussion already about it. I like the agreed solution in #4472 is far way more elegant than this patch 👍 however, I added one comment: open drain pull down is also valid for stm32l1 (according to the user manual). Feel free to merge this to fix the i2c (most of the changes will be replaced by your next PR). I tested it, but maybe someone can do a double check :-) |
OlegHahm
added
the
Community: Hack'n'ACK candidate
|
@haukepetersen ready to merge? |
|
nope, I would actually tend to close this in favor of #4862 |
miri64
removed
the
CI: ready for build
|
Then I do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API configuration does not allow open-drain to be configured in the GPIOs. However, the i2c needs to be configured as open-drain otherwise the output is corrupted.
In the following image you can see the output of the pins with not configured as open-drain. This effect is also observed by others
The patch just extends the behaviour and does not modify the existing one.