This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Update API specs related with dunning renaming (GWY-4415) #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunning: | ||
$ref: "#/definitions/Dunning" | ||
$ref: "#/definitions/PaymentRetry" | ||
# TODO: Rename to paymentRetryIndex when Payment will be refactored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use retryCount
/retryIndex
instead of paymentRetryIndex
?
👍 |
slavcodev
pushed a commit
that referenced
this pull request
Sep 15, 2016
slavcodev
added a commit
that referenced
this pull request
Oct 5, 2016
* Add Rules tag * Add rules paths * Add rules tracking paths * Add rules tracking paths * Implement EventType definition * Implement RuleSet definition * Implement RuleSetVersion definition * Implement Rule definition * Implement rule actions definitions * Implement rule actions definitions * Implement OnOff switcher definition * Add EventTrack definition * Add EventTrack definition * Rules: schedule dunning and schedule payment actions (#35) * Update dunning action * Update schedule payment action * ScheduledDunning * ScheduledDunningInstruction * ScheduledPayment * ScheduledPaymentInstruction * Add Schedule methods definitions * Rewrite schedule instruction objects * Rules: schedule dunning and schedule payment actions (#35) * Update dunning action * Update schedule payment action * ScheduledDunning * ScheduledDunningInstruction * ScheduledPayment * ScheduledPaymentInstruction * Add Schedule methods definitions * Rewrite schedule instruction objects * Update webhook headers defintions * Improve rules paths definitions * Improve rules paths definitions * Add headers to rules paths * Add headers to rules paths * Update EmailNotification definition * Update WebhookAuth * Update WebhookAuth * Remove Rules tracking specs. Will come in next PR * Remove Rules tracking specs. Will come in next PR * Re-write ScheduleDunning * Update SchedulePayment * Change event types enum * Rename weekday to day-of-week * Combine similar method to duration-of-time * Rename specific-time to event-time, method uses pointer to event attribute * Add full-price dunning policy * Fix time constraint to use pattern instead of invalid formatter * Remove rule set description * Fix time pattern * Fix event type enum * Temporary disable some events * Add Custom Events Rules API specs (#43) * Temporary disable some events * Add EventCustomType * Custom Events Rules API specs. * Add "PUT" and "DELETE" method to "custom-rules@{id}.yaml" path. * Add "PUT" and "DELETE" method to "custom-rules@{id}.yaml" path. * Fix "custom-rules@{id}.yaml". * Fix "custom-rules@{id}.yaml". * Added "custom-rules@{id}@history.yaml" path. * Added "custom-rules@{id}@history@{version}.yaml" path. * Add new breaking line to the end of the file. * Add new breaking line to the end of the file. * Add 'createdTime' to "CustomRuleSet". * Fix description for "custom-rules". * Add "eventType" as required attribute for "CustomRuleSet" definitions * Delete "DELETE" method for "custom-rules@{id}" path * Remove `createdTime` and make `id` `readOnly` attribute in `CustomRuleSet` definition * Delete 201 response from `custom-event@{id}` path * Remove CustomEventType duplicate * Make day-of-month more consistent * Move OnOff out of Rules, may be shared with another definitions * Seprate TimeUnit shared defintion * Change shedule instrument definition * Remove old scheduling defintion * Remove defintion duplicate * Change Rules endpoints (#59) * Change rules endpoints * Changes rules of custom events endpoints * Add title attribute to event definition * Add more tags to rules operations * Improve descriptions * Rename field authorization to auth * Revert schedule-dunning action to use dunningId * Remove X- prefix in custom headers * Combine all blacklists actions to one Make blacklisting simple by create one action, where need to specify type of blacklisted values. The type enum easy to extend in future. * Remove extra files defintion * Add minimum constraint in pick-gateway-account action weights * Update scheduling dunning action * Update trigger-webhooks action * Rename trigger-webhooks to trigger-webhook * Update send-emails action * Rename send-emails to send-email * Update rules aaction enum * Remove dun-payment action * Make none strategy common * Fix links definitions * Picking gateway account action (#100) * Rename AmountAdjustment attribute to method * Remove unnecessary attributes * Fix send-email action spec * Update API specs related with dunning renaming (GWY-4415) (#104) * Fix PaymentRetry definition (#106) * Modify GatewayAccountPickInstruction definition (#125) * Separate GatewayName and AcquirerName definitions * Update GatewayAccount definition * Modify GatewayAccountPickInstruction definition * Fix OchaPay acquirer name * Update EmailNotification Credential info (#131) * Update EmailNotification Credential info * Change credentialToken to credentialHash * Rename "afterPaymentRetryEndPolicy" to "afterRetryEndPolicy" (#132) * Remove duplicates * Remove email constraint in EmailNotification * Improve EmailNotification descriptions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.