This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
Rules API #24
Merged
Rules API #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| - schedule-payment | ||
| - stop-subscriptions | ||
| active: | ||
| description: Whether rule is active |
There was a problem hiding this comment.
Whether action is active, right?
|
I think its OK. Not sure strict is necessary. So +1. |
|
Updated conditions |
|
🔥 Please review, it is ready to merge now. |
slavcodev
force-pushed
the
rules
branch
9 times, most recently
from
4b4c705
to
692ee4f
Compare
|
For reference, here's a criteria structure for criteria: {
operation: 'or',
conditions: [
{
operation: 'and',
conditions: [
{
operation: 'not',
condition: {
operation: 'equals',
field: 'amount',
value: '100'
}
},
{
operation: 'gt',
field: 'amount',
value: '60'
}
]
},
{
operation: 'equals',
field: 'amount',
value: '50'
}
]
} |
| type: string | ||
| enum: | ||
| - invoice-due-time | ||
| # TODO: Consider to change name, e.q. amountInstruction, amountPolicy |
There was a problem hiding this comment.
I think amountPolicy is good
* Separate GatewayName and AcquirerName definitions * Update GatewayAccount definition * Modify GatewayAccountPickInstruction definition * Fix OchaPay acquirer name
* Update EmailNotification Credential info * Change credentialToken to credentialHash
|
|
Congrats it's merged. Thanks @ALL for contributing! ✌️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see docs preview here.