Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Rules webhook action #28

Merged
merged 2 commits into from
Apr 15, 2016
Merged

Rules webhook action #28

merged 2 commits into from
Apr 15, 2016

Conversation

slavcodev
Copy link
Contributor

blocks #24

@slavcodev slavcodev self-assigned this Apr 11, 2016
@slavcodev slavcodev force-pushed the rules-webhook-action branch 3 times, most recently from c869b0f to fd37807 Compare April 13, 2016 17:05
@creocoder
Copy link
Member

Ideal payload as i see that:

{
    "name": "Test webhook",
    "method": "POST",
    "url": "http://example.com",
    "query": {
        "param1": "value1",
        "param2": [
            "value2",
            "value3"
        ]
    },
    "auth": {
        "type": "foo",
        "custom1": "value1",
        "custom2": "value2",
        "custom3": "value3"
    },
    "headers": {
        "name1": "value1",
        "name2": [
            "value2",
            "value3"
        ],
    },
    "body": "some",
    "status": "active"
}

Only "name", "method" and "url" is required. Other fields are optional. Note that "auth" contains different props depends on "type".

@slavcodev slavcodev force-pushed the rules-webhook-action branch 2 times, most recently from 5f0a695 to 4c86117 Compare April 14, 2016 13:42
@slavcodev slavcodev force-pushed the rules-webhook-action branch 2 times, most recently from 2fb0607 to f3dfcb7 Compare April 15, 2016 21:57
@slavcodev
Copy link
Contributor Author

Screenshot

@slavcodev
Copy link
Contributor Author

Please review, it is ready to merge now.

@adamaltman
Copy link
Member

seems good to me 👍

@slavcodev
Copy link
Contributor Author

OK, I'm merging it at now, if any issues will appear, will fix separately.

@slavcodev slavcodev merged commit 31b50ce into rules Apr 15, 2016
@slavcodev slavcodev deleted the rules-webhook-action branch April 15, 2016 22:14
slavcodev added a commit that referenced this pull request Apr 20, 2016
slavcodev added a commit that referenced this pull request Apr 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants