-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 of 4 - refactor(config): sw-625 generate routes #1045
Merged
cdcabrera
merged 3 commits into
RedHatInsights:dev
from
cdcabrera:20230202-sw-625-generate-routes
Feb 21, 2023
Merged
1 of 4 - refactor(config): sw-625 generate routes #1045
cdcabrera
merged 3 commits into
RedHatInsights:dev
from
cdcabrera:20230202-sw-625-generate-routes
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
2 times, most recently
from
February 3, 2023 04:05
4cdd211
to
8a27059
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #1045 +/- ##
==========================================
+ Coverage 93.31% 93.54% +0.22%
==========================================
Files 122 122
Lines 4071 4075 +4
Branches 1662 1640 -22
==========================================
+ Hits 3799 3812 +13
+ Misses 255 246 -9
Partials 17 17
Continue to review full report at Codecov.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 3, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 3, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
from
February 3, 2023 04:31
8a27059
to
a96ce16
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 3, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 3, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
from
February 3, 2023 20:08
a96ce16
to
628f57e
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 6, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 8, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 8, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 8, 2023
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
from
February 8, 2023 01:13
14c288f
to
2cb1f30
Compare
cdcabrera
added a commit
that referenced
this pull request
Feb 9, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
cdcabrera
changed the title
refactor(config): sw-625 generate routes
1 of 4 - refactor(config): sw-625 generate routes
Feb 14, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 14, 2023
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
from
February 14, 2023 01:42
2cb1f30
to
60abaf0
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
from
February 15, 2023 20:43
60abaf0
to
5af7354
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 15, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 20, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 20, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 20, 2023
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
from
February 20, 2023 19:46
5af7354
to
150b9f0
Compare
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
force-pushed
the
20230202-sw-625-generate-routes
branch
from
February 20, 2023 20:55
150b9f0
to
f09907c
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 20, 2023
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 20, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Feb 20, 2023
cdcabrera
added a commit
that referenced
this pull request
Feb 21, 2023
cdcabrera
added a commit
that referenced
this pull request
Feb 21, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
that referenced
this pull request
Mar 2, 2023
cdcabrera
added a commit
that referenced
this pull request
Mar 2, 2023
* authentication, redirect errorRoute ref * build, spelling, jest, local run nav * config, generate products, routes * productView, replaced routerHelpers array ref * productViewMissing, updated routerHelpers * redirect, simplify, prep router npm update * redux, viewReducer, updated routerHelpers * router, prep router npm update * routerHelpers, refactor, removed unused funcs
cdcabrera
added a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
:productParameter
along with some other removals../src/config/products.js
. This is prep for moving towards the API configuration endpointHow to test
Coverage and basic unit test check
$ yarn
$ yarn test
Local run check
$ yarn
$ yarn start
Proxy run check
$ yarn
$ yarn start:proxy
[consoledot]/subscriptions/[some random path]/rhel
Example
...
Updates issue/story
sw-625