Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): npm updates #1100

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(build): npm updates

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm product views display as intended

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm product views display as intended

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added build 202304 project phase labels Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #1100 (0f0ef76) into dev (64d993f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1100   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         122      122           
  Lines        4212     4212           
  Branches     1715     1715           
=======================================
  Hits         3940     3940           
  Misses        255      255           
  Partials       17       17           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d993f...0f0ef76. Read the comment docs.

@cdcabrera
Copy link
Member Author

cdcabrera commented Apr 15, 2023

As of 20230414 #1101 helps toward resolving sw-1078 so we're separating out the commit to help with tracking issue resolution.

Reason:
If we had merged this set of npm updates earlier we would have inadvertently resolved parts of the issue without understanding what was causing it.

@cdcabrera cdcabrera merged commit cf889f3 into RedHatInsights:dev Apr 18, 2023
cdcabrera added a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202304 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants