Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWATCH-1078 #1101

Merged
Merged

Conversation

Hyperkid123
Copy link
Contributor

What's included

Bump notifications package

Local run check

Without changes

  1. update the NPM packages with $ yarn
  2. run yarn start:js-proxy
  3. open your browser at https://stage.foo.redhat.com:1337/beta/application-services/streams/streams
  4. in the left navigation navigate to /beta/application-services/subscriptions/streams (Subscriptions -> Streams for Apache Kafka)
  5. Runtime error will show up

With changes

  1. update the NPM packages with $ yarn
  2. run yarn start:js-proxy
  3. open your browser at https://stage.foo.redhat.com:1337/beta/application-services/streams/streams
  4. in the left navigation navigate to /beta/application-services/subscriptions/streams (Subscriptions -> Streams for Apache Kafka)
  5. UI functions normaly

Example

...

Updates issue/story

Fixes: https://issues.redhat.com/browse/SWATCH-1078

@cdcabrera cdcabrera changed the base branch from main to dev April 15, 2023 01:26
@codecov-commenter
Copy link

Codecov Report

Merging #1101 (b2f7627) into dev (64d993f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1101   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         122      122           
  Lines        4212     4212           
  Branches     1715     1715           
=======================================
  Hits         3940     3940           
  Misses        255      255           
  Partials       17       17           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d993f...b2f7627. Read the comment docs.

@cdcabrera cdcabrera merged commit d059bc3 into RedHatInsights:dev Apr 15, 2023
@Hyperkid123 Hyperkid123 deleted the bump-notifications-package branch April 17, 2023 07:16
cdcabrera pushed a commit that referenced this pull request Apr 18, 2023
cdcabrera pushed a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants