Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/339 Update local dev scripts to work in Linux #340

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 4, 2020

What's included

  • chore(build): issues/339 local run linux updates

    • docs, contributing.md filled in gaps on getting started
    • build, package.json npm scripts switched to bash
    • build, dev.chrome.sh, expire check, recursive copy, dotenv write

Notes

  • Iterative fix
  • Initial work to get linux up to par.
    • Fully fixes the mock local run, accessible via $ yarn start
    • Attempts to block the proxy run script with messaging when needing to run $ sudo docker...

How to test

Example

...

Updates issue/story

#339

@zanewoodfin

scripts/proxy.api.sh Outdated Show resolved Hide resolved
scripts/proxy.api.sh Show resolved Hide resolved
scripts/dev.chrome.sh Outdated Show resolved Hide resolved
scripts/proxy.api.sh Outdated Show resolved Hide resolved
scripts/proxy.api.sh Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #340 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #340   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files          55       55           
  Lines        1336     1336           
  Branches      315      315           
=======================================
  Hits         1235     1235           
  Misses         86       86           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b49253...cad189f. Read the comment docs.

@cdcabrera cdcabrera changed the title WIP Issues/339 Update local dev scripts to work in Linux Issues/339 Update local dev scripts to work in Linux Jul 9, 2020
@cdcabrera cdcabrera added the blocked Prevented from continuing label Jul 9, 2020
@cdcabrera
Copy link
Member Author

Adding the blocked label until PR #331 gets merged. Not up to potentially going back through QE review if we can wait until 7/13 for that merge to happen. It does highlight we need to start moving one off changes into additional feature release branches for holding... or possibly get the QA env fully functional

@cdcabrera cdcabrera removed the blocked Prevented from continuing label Jul 13, 2020
@cdcabrera
Copy link
Member Author

As of 7/13 unblocked'ish. One more task to release to the "staging" environment for 20200713 and this should be able to be rebased and merged into CI

* docs, contributing.md filled in gaps on getting started
* build, package.json npm scripts switched to bash
* build, dev.chrome.sh, expire check, recursive copy, dotenv write
* build, proxy.api.sh, expire check, separate darwin vs run.sh
@cdcabrera cdcabrera merged commit 85e2faa into RedHatInsights:ci Jul 13, 2020
cdcabrera added a commit that referenced this pull request Jul 20, 2020
* docs, contributing.md filled in gaps on getting started
* build, package.json npm scripts switched to bash
* build, dev.chrome.sh, expire check, recursive copy, dotenv write
* build, proxy.api.sh, expire check, separate darwin vs run.sh
cdcabrera added a commit that referenced this pull request Jul 28, 2020
* docs, contributing.md filled in gaps on getting started
* build, package.json npm scripts switched to bash
* build, dev.chrome.sh, expire check, recursive copy, dotenv write
* build, proxy.api.sh, expire check, separate darwin vs run.sh
cdcabrera added a commit that referenced this pull request Jul 30, 2020
* docs, contributing.md filled in gaps on getting started
* build, package.json npm scripts switched to bash
* build, dev.chrome.sh, expire check, recursive copy, dotenv write
* build, proxy.api.sh, expire check, separate darwin vs run.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants