Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Sync, Dev to Test (CI/QA-beta to CI/QA-stable) PF4 requested updates #334

Merged
merged 11 commits into from
Jul 20, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 2, 2020

Commits

Features

  1. loader issues/328 loading component (fix(routerTypes): issues/328 lazy load routing #337) (3d594c1)

Chores

  1. build issues/339 local run linux updates (Issues/339 Update local dev scripts to work in Linux #340) (85e2faa)

Bug Fixes

  1. tourView issues/289 remove unused tourView (PF, Platform NPM resource updates #326) (02d1c56)
  2. build issues/296 npm updates for pf4, platform (PF, Platform NPM resource updates #326) (66f971f)
  3. build issues/296 npm updates for pf4 react core (PF, Platform NPM resource updates #326) (c210245)
  4. build issues/296 npm updates for platform (PF, Platform NPM resource updates #326) (96c459e)
  5. messageView reposition empty state icon (047908c)
  6. rhsmServices,redux issues/10 inventory guests, state (fix(rhsmServices,redux): issues/10 inventory guests api, state #330) (c08e9b9)
  7. routerTypes issues/328 lazy load routing (fix(routerTypes): issues/328 lazy load routing #337) (3ddc519)
  8. graphCard,selectors issues/10 generic selectors (fix(inventoryListSelectors): issues/10 selectors
, state #343) (6e835c4)
  9. inventoryListSelectors issues/10 selectors, state (fix(inventoryListSelectors): issues/10 selectors
, state #343) (eb29e2a)

Notes

Related issues

#296

@cdcabrera cdcabrera added the blocked Prevented from continuing label Jul 2, 2020
* tourView, component removed
* i18n, remove tourView locale strings
* routerTypes, component removed
* tests, dist/integration file check
* tests, apply component displayNames to snapshots
* build, local dev run updates, header, branch parameter
* build, npm platform packages patched
* build, npm pf-react icons, tokens, styles, charts
* build, victory charts update sync to pf charts update
* graphCard, c3, cardTitle component
* graphCardChartLegend, c3, tooltip distance
* optinView, cardTitle and flex layout
* pageHeader, revert to pf title component
* select, isExpanded to isOpen prop
* toolbar, dataToolbar to toolbar component rename
* style, card header
* build, platform specific npm resources
* chartArea, fix resize method, relates to left nav
* pageHeader, revert title to platform version
* redux, middleware, reducer, types, update notifications import
* styles, move css files to src/index.js to avoid breaking sass
* build, dotenv host inventory guest API endpoint added
* redux actions, reducers, types for inventory guests
* rhsmServices, add base host inventory guests API
* rhsmApiTypes, common API response types, inventory guests
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #334 into qa will decrease coverage by 0.32%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##               qa     #334      +/-   ##
==========================================
- Coverage   92.53%   92.20%   -0.33%     
==========================================
  Files          56       56              
  Lines        1326     1347      +21     
  Branches      311      315       +4     
==========================================
+ Hits         1227     1242      +15     
- Misses         84       91       +7     
+ Partials       15       14       -1     
Impacted Files Coverage Δ
src/components/c3GraphCard/c3GraphCard.js 88.67% <ø> (ø)
...rc/components/c3GraphCard/c3GraphCardLegendItem.js 100.00% <ø> (ø)
src/components/form/select.js 100.00% <ø> (+1.75%) ⬆️
src/components/graphCard/graphCard.js 83.67% <ø> (ø)
src/components/graphCard/graphCardChartLegend.js 100.00% <ø> (ø)
src/components/messageView/messageView.js 100.00% <ø> (ø)
src/components/optinView/optinView.js 95.45% <ø> (ø)
src/components/pageLayout/pageHeader.js 100.00% <ø> (ø)
src/components/pageLayout/pageSection.js 100.00% <ø> (ø)
src/components/pageLayout/pageToolbar.js 100.00% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea9173...b7436ee. Read the comment docs.

* docs, contributing.md filled in gaps on getting started
* build, package.json npm scripts switched to bash
* build, dev.chrome.sh, expire check, recursive copy, dotenv write
* build, proxy.api.sh, expire check, separate darwin vs run.sh
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Jul 15, 2020
@cdcabrera cdcabrera changed the title WIP Environment Sync, Dev to Test (CI/QA-beta to CI/QA-stable) PF4 requested updates Environment Sync, Dev to Test (CI/QA-beta to CI/QA-stable) PF4 requested updates Jul 15, 2020
* loader, basic loading component
* build, frontend and notifications packages patched
* build, integration dist/file output test
* router, apply react suspense loading
* routerTypes, react lazy app routes
* graphCard, selector sequence consistency
* selectors, user, view, graphCard, code and test consistency
* inventoryReducer, hostsGuests rename, test snapshot
* inventoryListSelectors, initial selector, memoize/cache
* guestListSelectors, initial selector,  memoize/cache
* reduxHelpers, annotation
* rhsmActions, hostsGuests test
* rhsmServices, mock data, delay, annotations
Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cdcabrera cdcabrera mentioned this pull request Jul 20, 2020
@cdcabrera cdcabrera merged commit e72bb01 into qa Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants