fix(routerTypes): issues/328 lazy load routing #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
changed the title
|
As of 7/13 unblocked. This should be able to be rebased and merged into CI |
cdcabrera
force-pushed
the
issues/328
branch
2 times, most recently
from
3dd46a5
to
6a713fe
Compare
Codecov Report
@@ Coverage Diff @@
## ci #337 +/- ##
==========================================
- Coverage 92.44% 92.20% -0.24%
==========================================
Files 55 56 +1
Lines 1336 1347 +11
Branches 315 316 +1
==========================================
+ Hits 1235 1242 +7
- Misses 86 90 +4
Partials 15 15
Continue to review full report at Codecov.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jul 14, 2020
* build, frontend and notifications packages patched * build, integration dist/file output test * router, apply react suspense loading * routerTypes, react lazy app routes
* loader, basic loading component
* build, frontend and notifications packages patched * build, integration dist/file output test * router, apply react suspense loading * routerTypes, react lazy app routes
cdcabrera
added a commit
that referenced
this pull request
Jul 15, 2020
* loader, basic loading component
cdcabrera
added a commit
that referenced
this pull request
Jul 17, 2020
* loader, basic loading component
cdcabrera
added a commit
that referenced
this pull request
Jul 17, 2020
* build, frontend and notifications packages patched * build, integration dist/file output test * router, apply react suspense loading * routerTypes, react lazy app routes
cdcabrera
added a commit
that referenced
this pull request
Jul 20, 2020
* loader, basic loading component
cdcabrera
added a commit
that referenced
this pull request
Jul 20, 2020
* build, frontend and notifications packages patched * build, integration dist/file output test * router, apply react suspense loading * routerTypes, react lazy app routes
cdcabrera
added a commit
that referenced
this pull request
Jul 28, 2020
* loader, basic loading component
cdcabrera
added a commit
that referenced
this pull request
Jul 28, 2020
* build, frontend and notifications packages patched * build, integration dist/file output test * router, apply react suspense loading * routerTypes, react lazy app routes
cdcabrera
added a commit
that referenced
this pull request
Jul 30, 2020
* loader, basic loading component
cdcabrera
added a commit
that referenced
this pull request
Jul 30, 2020
* build, frontend and notifications packages patched * build, integration dist/file output test * router, apply react suspense loading * routerTypes, react lazy app routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
and Environment Sync, Dev to Test (CI/QA-beta to CI/QA-stable) PF4 requested updates #334ARE MERGEDHow to test
Proxy run check
$ yarn$ yarn start:proxyExample
After
Before
Updates issue/story
#328