Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redirect): issues/328 lazy load routing #344

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 17, 2020

What's included

  • fix(redirect): issues/328 lazy load routing

    • redirect, apply suspense for lazy loaded redirect route
  • fix(loader): issues/328 loading component

    • loader, resource path consistency

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. login with credentials
  5. delete the users/account optin
  6. refresh the page, it should render the optin view accordingly

Example

...

Updates issue/story

Closes #328
Updates #342

* loader, resource path consistency
* redirect, apply suspense for lazy loaded redirect route
@cdcabrera cdcabrera merged commit b7436ee into RedHatInsights:ci Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant