Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/10 Inventory listing support components, table and loader #346

Merged
merged 4 commits into from
Jul 24, 2020
Merged

issues/10 Inventory listing support components, table and loader #346

merged 4 commits into from
Jul 24, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 23, 2020 •
edited
Loading

What's included

  • fix(loader,graphCard): issues/10 extend loader types
    • loader, apply tableSkeleton, paragraph loaders, update chart, title
    • graphCard, apply skeleton paragraph loader
    • styles, skeleton chart
  • feat(table,empty,skeleton): issues/10 add table component
    • table, convenience wrapper for pf tables
    • tableEmpty, convenience wrapper for platform comp, empty state
    • tableSkeleton, simplified wrapper for skeleton table, allow variants
    • locales, i18n, table strings
    • styles, correct pf table behavior on small screens, no border fix
  • fix(messageView): remove unnecessary emptyState alias
  • fix(helpers): add isDate check, enhance isPromise
    • helpers, isDate, enhance isPromise, async promise-like check

Notes

  • Support component work, behind the scenes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Example

...

Updates issue/story

Updates #10

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ci@31a6a23). Click here to learn what that means.
The diff coverage is 91.80%.

Impacted file tree graph

@@          Coverage Diff          @@
##             ci     #346   +/-   ##
=====================================
  Coverage      ?   92.40%           
=====================================
  Files         ?       61           
  Lines         ?     1475           
  Branches      ?      349           
=====================================
  Hits          ?     1363           
  Misses        ?       98           
  Partials      ?       14
Impacted Files Coverage Δ
src/components/graphCard/graphCard.js 83.67% <ø> (ø)
src/components/messageView/messageView.js 100.00% <ø> (ø)
src/components/table/table.js 88.37% <88.37%> (ø)
src/common/helpers.js 100.00% <100.00%> (ø)
src/components/loader/loader.js 100.00% <100.00%> (ø)
src/components/table/tableEmpty.js 100.00% <100.00%> (ø)
src/components/table/tableSkeleton.js 100.00% <100.00%> (ø)
src/redux/types/rhsmTypes.js 100.00% <0.00%> (ø)
src/components/chartArea/chartArea.js 87.64% <0.00%> (ø)
src/components/router/routerTypes.js 60.00% <0.00%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a6a23...5c6f8c2. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jul 24, 2020
@cdcabrera
feat(table,empty,skeleton): issues/10 add table component (RedHatInsi…
c771ab1 
…ghts#346)

* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jul 24, 2020
@cdcabrera
fix(loader,graphCard): issues/10 extend loader types (RedHatInsights#346
c85cb19 
)

* loader, tableSkeleton, paragraph loaders, update chart, title
* graphCard, apply skeleton paragraph loader
* styles, skeleton chart
@cdcabrera cdcabrera changed the title WIP issues/10 Inventory listing support components, table and loader issues/10 Inventory listing support components, table and loader Jul 24, 2020
@cdcabrera
feat(table,empty,skeleton): issues/10 add table component (RedHatInsi…
dcbd997 
…ghts#346)

* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
@cdcabrera
fix(loader,graphCard): issues/10 extend loader types (RedHatInsights#346
5c6f8c2 
)

* loader, tableSkeleton, paragraph loaders, update chart, title
* graphCard, apply skeleton paragraph loader
* styles, skeleton chart
@cdcabrera cdcabrera merged commit 06c95e5 into RedHatInsights:ci Jul 24, 2020
cdcabrera added a commit that referenced this pull request Jul 24, 2020
@cdcabrera
feat(table,empty,skeleton): issues/10 add table component (#346)
d9b0c52 
* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
@cdcabrera cdcabrera mentioned this pull request Jul 24, 2020
Merged
cdcabrera added a commit that referenced this pull request Jul 24, 2020
@cdcabrera
feat(table,empty,skeleton): issues/10 add table component (#346)
f6f85c8 
* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
cdcabrera added a commit that referenced this pull request Jul 24, 2020
@cdcabrera
fix(loader,graphCard): issues/10 extend loader types (#346)
abd4302 
* loader, tableSkeleton, paragraph loaders, update chart, title
* graphCard, apply skeleton paragraph loader
* styles, skeleton chart
cdcabrera added a commit that referenced this pull request Jul 24, 2020
@cdcabrera
feat(table,empty,skeleton): issues/10 add table component (#346)
9869c86 
* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
cdcabrera added a commit that referenced this pull request Jul 24, 2020
@cdcabrera
fix(loader,graphCard): issues/10 extend loader types (#346)
95939c1 
* loader, tableSkeleton, paragraph loaders, update chart, title
* graphCard, apply skeleton paragraph loader
* styles, skeleton chart
@cdcabrera cdcabrera mentioned this pull request Jul 24, 2020
Merged
cdcabrera added a commit that referenced this pull request Jul 28, 2020
@cdcabrera
feat(table,empty,skeleton): issues/10 add table component (#346)
84fe51e 
* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
cdcabrera added a commit that referenced this pull request Jul 28, 2020
@cdcabrera
fix(loader,graphCard): issues/10 extend loader types (#346)
4889942 
* loader, tableSkeleton, paragraph loaders, update chart, title
* graphCard, apply skeleton paragraph loader
* styles, skeleton chart
@cdcabrera cdcabrera mentioned this pull request Jul 28, 2020
Merged
cdcabrera added a commit that referenced this pull request Jul 30, 2020
@cdcabrera
feat(table,empty,skeleton): issues/10 add table component (#346)
fc87bdf 
* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
cdcabrera added a commit that referenced this pull request Jul 30, 2020
@cdcabrera
fix(loader,graphCard): issues/10 extend loader types (#346)
c2c8600 
* loader, tableSkeleton, paragraph loaders, update chart, title
* graphCard, apply skeleton paragraph loader
* styles, skeleton chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-commenter