Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Sync, Dev to Test #347

Merged
merged 9 commits into from
Jul 24, 2020
Merged

Environment Sync, Dev to Test #347

merged 9 commits into from
Jul 24, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 23, 2020

Chores

  1. build npm updates (NPM package updates #345) (fc3383b)
  2. docs readme, remove broken image (febdf7a)

Bug Fixes

  1. build npm updates for pf4 react core (NPM package updates #345) (cb67c4b)
  2. build npm lint updates (NPM package updates #345) (5e1eca5)
  3. build npm victory updates (NPM package updates #345) (6e963cd)
  4. helpers add isDate check, enhance isPromise (cb317b9)
  5. messageView remove unnecessary emptyState alias (8459692)
  6. loader,graphCard issues/10 extend loader types (issues/10 Inventory listing support components, table and loader #346) (abd4302)

Features

  1. table,empty,skeleton issues/10 add table component (issues/10 Inventory listing support components, table and loader #346) (f6f85c8)

* build, adjust displayName test helper
* graphCardChartLegend, c3, tooltip distance, enableFlip props
* select, test snapshots
* build, jsdoc annotation updates
* build, victory tests update
* readme, remove broken image
* contributing, os support copy
* helpers, isDate, enhance isPromise, async promise-like check
* table, convenience wrapper for pf tables
* tableEmpty, convenience wrapper for platform comp, empty state
* tableSkeleton, wrapper for skeleton table, allow variants
* locales, i18n, table strings
* styles, correct pf table behavior on small screens, no border fix
* loader, tableSkeleton, paragraph loaders, update chart, title
* graphCard, apply skeleton paragraph loader
* styles, skeleton chart
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (qa@e72bb01). Click here to learn what that means.
The diff coverage is 91.80%.

Impacted file tree graph

@@          Coverage Diff          @@
##             qa     #347   +/-   ##
=====================================
  Coverage      ?   92.40%           
=====================================
  Files         ?       61           
  Lines         ?     1475           
  Branches      ?      349           
=====================================
  Hits          ?     1363           
  Misses        ?       98           
  Partials      ?       14           
Impacted Files Coverage Δ
src/components/c3GraphCard/c3GraphCardHelpers.js 76.92% <ø> (ø)
...rc/components/c3GraphCard/c3GraphCardLegendItem.js 100.00% <ø> (ø)
src/components/graphCard/graphCard.js 83.67% <ø> (ø)
src/components/graphCard/graphCardChartLegend.js 100.00% <ø> (ø)
src/components/messageView/messageView.js 100.00% <ø> (ø)
src/components/table/table.js 88.37% <88.37%> (ø)
src/common/helpers.js 100.00% <100.00%> (ø)
src/components/loader/loader.js 100.00% <100.00%> (ø)
src/components/table/tableEmpty.js 100.00% <100.00%> (ø)
src/components/table/tableSkeleton.js 100.00% <100.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72bb01...abd4302. Read the comment docs.

@cdcabrera cdcabrera changed the title WIP Environment Sync, Dev to Test Environment Sync, Dev to Test Jul 24, 2020
@cdcabrera cdcabrera merged commit 95939c1 into qa Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants