Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageHeader): issues/305 add bottom margin to h1 #357

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

zanewoodfin
Copy link
Contributor

@zanewoodfin zanewoodfin commented Jul 29, 2020

What's included

  • fix(pageHeader): issues/305 add bottom margin to h1
    • build, update frontend-components minor version to remove inline style from h1
    • pageHeader, add class to h1 for 8px bottom margin
    • style, rename files for consistency

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. visit http://localhost:3000/rhel-sw/all
  4. inspect the "Red Hat Enterprise Linux" page heading and confirm it has 8px bottom margin

Example

Before

margin_before

After

margin_after

Updates issue/story

Fixes pull request #348
Helps resolve issue #305

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #357 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #357   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files          61       61           
  Lines        1476     1476           
  Branches      349      349           
=======================================
  Hits         1364     1364           
  Misses         98       98           
  Partials       14       14           
Impacted Files Coverage Δ
src/components/pageLayout/pageHeader.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c665a...0fa9a55. Read the comment docs.

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we missed the inline-block... trying not to totally remove the inline quality from the H1, not clear why it's like that

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Confirmed!

Screen Shot 2020-07-30 at 7 15 23 PM

@cdcabrera cdcabrera merged commit ad3d99a into RedHatInsights:ci Jul 30, 2020
cdcabrera pushed a commit that referenced this pull request Jul 31, 2020
* build, platform package update for h1
* pageHeader, pf class added
* style, file names for consistency
cdcabrera pushed a commit that referenced this pull request Aug 6, 2020
* build, platform package update for h1
* pageHeader, pf class added
* style, file names for consistency
cdcabrera pushed a commit that referenced this pull request Aug 17, 2020
* build, platform package update for h1
* pageHeader, pf class added
* style, file names for consistency
cdcabrera pushed a commit that referenced this pull request Aug 24, 2020
* build, platform package update for h1
* pageHeader, pf class added
* style, file names for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants