Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Sync, Dev to Test #362

Merged
merged 15 commits into from
Aug 6, 2020
Merged

Environment Sync, Dev to Test #362

merged 15 commits into from
Aug 6, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 31, 2020 •
edited
Loading

Features

  1. rhelView, issues/305 add sub heading (feat(rhelView, openshiftView): issues/305 add sub heading #348) (dd2ae13)
  2. toolbar issues/10 add usage filter (feat(toolbar): issues/10 add usage filter #361) (b14aaf2)

Bug Fixes

  1. pageHeader issues/305 add bottom margin to h1 (fix(pageHeader): issues/305 add bottom margin to h1 #357) (8b631d8)
  2. i18n,translate issues/354 remove withTranslation (fix(i18n,translate): issues/354 remove withTranslation #355) (e830b51)
  3. select issues/10 pf toggleIcon prop, toggleText (Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360) (c0cc484)
  4. redux issues/10 expand rhsmTypes for filtering (Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360) (f2f8948)
  5. graphCard,rhelView,openshiftView issues/10 query prop (Issues/10 updates, select toggle prop, expanded rhsmTypes, renamed "graphQuery" to "query" #360) (d20307b)
  6. queryTypes issues/10 rhsm to query type (feat(toolbar): issues/10 add usage filter #361) (861ccb2)
  7. testing commit message length (fix(testing): commit message length #366) (2b2e1e0)
  8. toolbar issues/10 default usage filter category (fix(toolbar): issues/10 default usage filter category #368) (87f736a)
  9. pageHeader issues/367 subheading external link icon (fix(pageHeader): update subheading external link icon #369) (394b7ff)
  10. tourView issues/359 remove vestigial tour stylesheet (chore(tourView): issues/359 remove vestigial tour stylesheet #370) (981ac6a)
  11. pageHeader issues/305 apply locale product context (fix(pageHeader): issues/305 apply locale product context #371) (aa88ec9)

Chores

  1. build issues/333 update min test coverage (chore(build): issues/333 update min test coverage #363) (93c5d5d)
  2. build issues/335 update Node 10 references to 12 (chore(build): update Node 10 references to Node 12 #364) (bd5874d)

zanewoodfin and others added 3 commits July 30, 2020 20:35
@zanewoodfin @cdcabrera
feat(rhelView, openshiftView): issues/305 add sub heading (#348)
dd2ae13
@zanewoodfin @cdcabrera
fix(pageHeader): issues/305 add bottom margin to h1 (#357)
8b631d8 
* build, platform package update for h1
* pageHeader, pf class added
* style, file names for consistency
@cdcabrera
fix(i18n,translate): issues/354 remove withTranslation (#355)
e830b51 
* i18n, replace withTranslation new HOC, use translate function
* redux, remove withTranslation convenience HOCs
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020 •
edited
Loading

Codecov Report

Merging #362 into qa will increase coverage by 0.06%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##               qa     #362      +/-   ##
==========================================
+ Coverage   92.41%   92.47%   +0.06%     
==========================================
  Files          61       64       +3     
  Lines        1476     1528      +52     
  Branches      349      355       +6     
==========================================
+ Hits         1364     1413      +49     
- Misses         98      100       +2     
- Partials       14       15       +1
Impacted Files Coverage Δ
src/components/graphCard/graphCardChartTooltip.js 100.00% <ø> (ø)
src/components/table/table.js 88.09% <ø> (-0.28%) ⬇️
src/components/table/tableSkeleton.js 100.00% <ø> (ø)
src/redux/selectors/graphCardSelectors.js 100.00% <ø> (ø)
src/redux/types/index.js 100.00% <ø> (ø)
src/redux/types/rhsmTypes.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/toolbar/toolbar.js 92.59% <93.33%> (-2.87%) ⬇️
src/components/authentication/authentication.js 60.60% <100.00%> (ø)
src/components/c3GraphCard/c3GraphCard.js 88.67% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732120a...aa88ec9. Read the comment docs.

@cdcabrera
fix(select): issues/10 pf toggleIcon prop, toggleText (#360)
c0cc484
@cdcabrera
fix(redux): issues/10 expand rhsmTypes for filtering (#360)
f2f8948 
* rhsmTypes, add filter types, align naming
* rhsmServices, expand mock
* toolbar, rename SLA rhsmType
* viewReducer, apply filter types
@cdcabrera
fix(graphCard,rhelView,openshiftView): issues/10 query prop (#360)
d20307b 
* graphCard, c3GraphCard, prop graphQuery to query
* rhelView, openshiftView, toolbar, graphQuery to query
* redux, viewReducer, selectors, graphQuery to query
zanewoodfin and others added 8 commits August 4, 2020 13:27
@zanewoodfin
chore(build): issues/333 update min test coverage (#363)
93c5d5d
@zanewoodfin
chore(build): issues/335 update Node 10 references to 12 (#364)
bd5874d
@cdcabrera
fix(queryTypes): issues/10 rhsm to query type (#361)
861ccb2 
* graphCard, c3graphCard, filter to query name
* queryTypes, rhsmTypes, filter to query, align naming
* toolbar, apply query SLA type
* viewReducer, apply query types
@cdcabrera
feat(toolbar): issues/10 add usage filter (#361)
b14aaf2 
* i18n, locale strings for usage
* toolbar, toolbarTypes, add usage filter
* redux, middleware, multiActionMiddleware, add array of actions
* redux, reducers, types, toolbar addtions
* styles, add toolbar styles
@cdcabrera
fix(testing): commit message length (#366)
2b2e1e0
@cdcabrera
fix(toolbar): issues/10 default usage filter category (#368)
87f736a 
* toolbar, default filter category, soft filter reset
@zanewoodfin @cdcabrera
fix(pageHeader): issues/367 subheading external link icon (#369)
394b7ff
@zanewoodfin @cdcabrera
fix(tourView): issues/359 remove vestigial tour stylesheet (#370)
981ac6a
@cdcabrera
fix(pageHeader): issues/305 apply locale product context (#371)
aa88ec9 
* locale, i18n, appName, product context strings
* openshiftView, rhelView, apply appName, product context
* pageHeader, appName param, product context
* table, apply appName clean up
@cdcabrera cdcabrera changed the title WIP Environment Sync, Dev to Test Environment Sync, Dev to Test Aug 6, 2020
@cdcabrera cdcabrera merged commit 51234d3 into qa Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdcabrera @codecov-commenter @zanewoodfin