Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tourView): issues/359 remove vestigial tour stylesheet #370

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

zanewoodfin
Copy link
Contributor

What's included

  • chore(tourView): issues/359 remove vestigial tour stylesheet
    • tourView, remove associated stylesheet for previously removed component

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. click around app to confirm nothing looks off

Updates issue/story

Updates #359

@zanewoodfin zanewoodfin linked an issue Aug 5, 2020 that may be closed by this pull request
2 tasks
@zanewoodfin
Copy link
Contributor Author

zanewoodfin commented Aug 5, 2020

There was only one rule in the deleted stylesheet. I searched the codebase and found no instances of the associated classname. Then I went back to the pr that added this style to see what it was added for to confirm that code was gone. This stylesheet seems to not be used any more.

@codecov-commenter
Copy link

Codecov Report

Merging #370 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #370   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          64       64           
  Lines        1528     1528           
  Branches      355      355           
=======================================
  Hits         1413     1413           
  Misses        100      100           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f736a...9da2dc7. Read the comment docs.

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm debating an update to the commit message, like fix, since originally this did affect a layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused styles for removed tourView component
3 participants