Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventoryListSelectors): issues/10 last seen date context #382

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(inventoryListSelectors): issues/10 last seen date context
    • inventoryListSelectors, guestsList, correct last seen date context

Notes

  • this is a subtle behind the scenes updates that most users will not notice. it affects the time displayed for last seen

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Example

Screen Shot 2020-08-20 at 3 15 48 PM

Updates issue/story

updates #10

* inventoryListSelectors, guestsList, correct last seen date context
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #382 into ci will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #382   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          68       68           
  Lines        1651     1651           
  Branches      382      382           
=======================================
  Hits         1526     1526           
  Misses        109      109           
  Partials       16       16           
Impacted Files Coverage Δ
src/redux/selectors/guestsListSelectors.js 97.14% <100.00%> (ø)
src/redux/selectors/inventoryListSelectors.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab019f1...90daf12. Read the comment docs.

@cdcabrera cdcabrera merged commit c9bf687 into RedHatInsights:ci Aug 21, 2020
cdcabrera added a commit that referenced this pull request Aug 25, 2020
* inventoryListSelectors, guestsList, correct last seen date context
cdcabrera added a commit that referenced this pull request Aug 25, 2020
* inventoryListSelectors, guestsList, correct last seen date context
cdcabrera added a commit that referenced this pull request Sep 16, 2020
* inventoryListSelectors, guestsList, correct last seen date context
cdcabrera added a commit that referenced this pull request Sep 29, 2020
* inventoryListSelectors, guestsList, correct last seen date context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants