-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft release 1.0.0, Sync Test to Stage #417
Conversation
* table, pf fixme annotations, align to pf title/content prop * tableSkeleton, switch to generic node, related to pf title align
* inventoryListSelectors, itemCount, deep equals adjustment * rhsmApiTypes, added inventory_id * reduxHelpers add setNormalizedResponse * rhsmServices mock update
* styles, min-heights graphCard, inventoryList * inventoryList, initial inventory list display * inventoryListHelpers, parse table cells * inventoryList perPageDefault for skeleton loader * pagination, initial pagination * rhelView, openshiftView add inventoryList * locale, i18n strings
* c3GraphCard, align to graphCard * graphCard, align to inventoryList card
* rhsmApiTypes, apply api query types for individual api calls * graphCard, c3, types updates, centralize getQuery * rhelView, openshiftView, types updates * redux, actions, selectors, reducer, types updates
* apiQueries, reduxHelpers, parse queries for specific API endpoints * openshiftView, rhelView, apply parseRhsmQuery
* inventoryListSelectors, guestsList, correct last seen date context
* i18n, locale inventory header * guestsList, add an infinite scrolling table component * inventoryList, activate guestsList, missing annotations * openshiftView, rhelView, pass guests lists filters * apiQueries, rhsmApiTypes, guests schema for query-strings * guestsListSelectors, cache removed, infinite scroll conflicts * rhsmServices, mock for guests response * style, file rename, table scroll
* i18n, uom strings * openshiftView, filter, default props avoid 2x XHR on load * redux, queryTypes, viewReducer, sort statements, uom filter * rhsmApiTypes, uom types
* openshiftView, pass productId to toolbar, page reset helper * pagination, productId as primary state update * paginationHelper, centralize page reset * rhelView, pass productId to toolbar * toolbar, page reset helper on filter selection and clear
Codecov Report
@@ Coverage Diff @@
## stage #417 +/- ##
==========================================
+ Coverage 92.40% 92.71% +0.30%
==========================================
Files 64 69 +5
Lines 1528 1716 +188
Branches 355 392 +37
==========================================
+ Hits 1412 1591 +179
- Misses 101 110 +9
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viewed features and double-checked with @cdcabrera for any possible doc impact from the bug fixes. Approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 👍
Looks good!
We'll give the API a chance to run stand-alone over the weekend, then look at merging this into Prod-beta around Monday 2020-09-14 |
@cdcabrera could we get this in #421 ? |
Blocked until #421 can be implemented, reviewed and merged from QA branch |
* openshiftView,rhelView, viewId to productLabel, avoid conflicts * c3graphCard, annotation for viewId to productLabel * graphCard,Tooltip,Legend, product,shortLabel to productLabel * pageHeader, viewId to productLabel
* inventoryListSelectors, combine props, productId, viewId queries * openshiftView, rhelView, initialInventoryQuery * pagination, consolidate limit and page dispatches * paginationHelpers, removed * toolbar, replace paginationHelpers with clear all offset * viewReducer, queryTypes, added new action type
Issue is fixed and we are good with this release 🎉 |
Features
Bug Fixes
Styles
Chores