Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft release 1.0.0, Sync Test to Stage #417

Merged
merged 26 commits into from
Sep 16, 2020
Merged

Draft release 1.0.0, Sync Test to Stage #417

merged 26 commits into from
Sep 16, 2020

Conversation

cdcabrera
Copy link
Member

Features

  1. inventoryList,views issues/10 display inventory list (feat(inventoryList,views): issues/10 display inventory list #372) (5f1ca14)
  2. messageView issues/320 app-level maintenance mode (feat(maintenanceView): issues/320 application level maintenance mode #379) (27182b4)
  3. guestsList issues/10 display infinite table listing (Display expandable guestsList for inventory, issues/10 #390) (65b65f0)
  4. authentication issues/373 use platform not authorized (feat(authentication): issues/373 use platform not authorized #402) (713a55f)

Bug Fixes

  1. table,tableSkeleton issues/10 align content prop to pf (feat(inventoryList,views): issues/10 display inventory list #372) (7322940)
  2. inventoryListSelectors issues/10 itemCount, deep equals (feat(inventoryList,views): issues/10 display inventory list #372) (d37ab77)
  3. graphCard,c3GraphCard issues/10 align card component (feat(inventoryList,views): issues/10 display inventory list #372) (497771c)
  4. rhsmApiTypes issues/380 api query types (Fix, apply unique queries for API endpoints Issues/380 #381) (a3bc804)
  5. apiQueries,reduxHelpers issues/380 query schema (Fix, apply unique queries for API endpoints Issues/380 #381) (10eea39)
  6. graphCard issues/380 graph refresh on query (fix(graphCard): issues/380 graph refresh on query #384) (850eb65)
  7. inventoryListSelectors issues/10 last seen date context (fix(inventoryListSelectors): issues/10 last seen date context #382) (f3aee0e)
  8. inventoryList issues/10 missing platform component (fix(inventoryList): issues/10 missing platform component #385) (12b4b25)
  9. testing platform component import exceptions (fix(testing): platform component import exceptions #386) (c889548)
  10. graphCard,chartArea issues/365 increase stroke width (fix(graphCard,chartArea): issues/365 increase stroke width #392) (ef0333a)
  11. tableSkeleton allow table with zero rows (Display expandable guestsList for inventory, issues/10 #390) (00c001b)
  12. guestsList issues/10 increase paging limit (Display expandable guestsList for inventory, issues/10 #390) (7000f43)
  13. pagination issues/400 page reset on limit update (fix(pagination): issues/400 page reset on limit update #405) (a8a580b)
  14. openshiftView issues/383 apply uom query filter (fix(openshiftView): issues/383 apply uom query filter #408) (3b7995a)
  15. pagination,toolbar issues/400 page reset filter update (fix(toolbar): issues/400 page reset on filter update #412) (e0517fa)
  16. guestsList avoid boolean, remove nullish coalescing op (fix(toolbar,openshiftView): issues/400 page reset on filter update #413) (77ec6bd)

Styles

  1. pageLayout issues/391 remove gray padding (style(pageLayout): issues/391 remove gray padding #401) (f67c60c)

Chores

  1. rhsmServices expand system inventory mock (fix(pagination): issues/400 page reset on limit update #405) (a3159d1)
  2. build expand changelog displayed commits (chore(build): expand changelog displayed commits #415) (63a72f9)

cdcabrera and others added 23 commits August 25, 2020 14:01
* table, pf fixme annotations, align to pf title/content prop
* tableSkeleton, switch to generic node, related to pf title align
* inventoryListSelectors, itemCount, deep equals adjustment
* rhsmApiTypes, added inventory_id
* reduxHelpers add setNormalizedResponse
* rhsmServices mock update
* styles, min-heights graphCard, inventoryList
* inventoryList, initial inventory list display
* inventoryListHelpers, parse table cells
* inventoryList perPageDefault for skeleton loader
* pagination, initial pagination
* rhelView, openshiftView add inventoryList
* locale, i18n strings
* c3GraphCard, align to graphCard
* graphCard, align to inventoryList card
* rhsmApiTypes, apply api query types for individual api calls
* graphCard, c3, types updates, centralize getQuery
* rhelView, openshiftView, types updates
* redux, actions, selectors, reducer, types updates
* apiQueries, reduxHelpers, parse queries for specific API endpoints
* openshiftView, rhelView, apply parseRhsmQuery
* inventoryListSelectors, guestsList, correct last seen date context
* i18n, locale inventory header
* guestsList, add an infinite scrolling table component
* inventoryList, activate guestsList, missing annotations
* openshiftView, rhelView, pass guests lists filters
* apiQueries, rhsmApiTypes, guests schema for query-strings
* guestsListSelectors, cache removed, infinite scroll conflicts
* rhsmServices, mock for guests response
* style, file rename, table scroll
* i18n, uom strings
* openshiftView, filter, default props avoid 2x XHR on load
* redux, queryTypes, viewReducer, sort statements, uom filter
* rhsmApiTypes, uom types
* openshiftView, pass productId to toolbar, page reset helper
* pagination, productId as primary state update
* paginationHelper, centralize page reset
* rhelView, pass productId to toolbar
* toolbar, page reset helper on filter selection and clear
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #417 into stage will increase coverage by 0.30%.
The diff coverage is 93.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##            stage     #417      +/-   ##
==========================================
+ Coverage   92.40%   92.71%   +0.30%     
==========================================
  Files          64       69       +5     
  Lines        1528     1716     +188     
  Branches      355      392      +37     
==========================================
+ Hits         1412     1591     +179     
- Misses        101      110       +9     
  Partials       15       15              
Impacted Files Coverage Δ
src/components/pageLayout/pageLayout.js 100.00% <ø> (ø)
src/components/toolbar/toolbarTypes.js 100.00% <ø> (ø)
src/redux/selectors/viewSelectors.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/authentication/authentication.js 60.00% <50.00%> (-0.61%) ⬇️
src/components/table/table.js 87.75% <69.23%> (-0.35%) ⬇️
src/components/graphCard/graphCard.js 84.31% <83.33%> (+0.64%) ⬆️
src/components/rhelView/rhelView.js 88.88% <83.33%> (-11.12%) ⬇️
src/redux/reducers/viewReducer.js 94.11% <83.33%> (-5.89%) ⬇️
src/components/inventoryList/inventoryList.js 89.65% <89.65%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7d33c...fa546b3. Read the comment docs.

Copy link

@jlprevatt-zz jlprevatt-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewed features and double-checked with @cdcabrera for any possible doc impact from the bug fixes. Approving.

Copy link
Member

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 👍

Looks good!

@cdcabrera
Copy link
Member Author

cdcabrera commented Sep 11, 2020

We'll give the API a chance to run stand-alone over the weekend, then look at merging this into Prod-beta around Monday 2020-09-14

@ntkathole
Copy link
Member

@cdcabrera could we get this in #421 ?

@cdcabrera
Copy link
Member Author

Blocked until #421 can be implemented, reviewed and merged from QA branch

@cdcabrera cdcabrera added the blocked Prevented from continuing label Sep 14, 2020
* openshiftView,rhelView, viewId to productLabel, avoid conflicts
* c3graphCard, annotation for viewId to productLabel
* graphCard,Tooltip,Legend, product,shortLabel to productLabel
* pageHeader, viewId to productLabel
* inventoryListSelectors, combine props, productId, viewId queries
* openshiftView, rhelView, initialInventoryQuery
* pagination, consolidate limit and page dispatches
* paginationHelpers, removed
* toolbar, replace paginationHelpers with clear all offset
* viewReducer, queryTypes, added new action type
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Sep 16, 2020
@ntkathole
Copy link
Member

Issue is fixed and we are good with this release 🎉

@cdcabrera cdcabrera merged commit c124be0 into stage Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants