-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pagination): issues/400 page reset on limit update #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
issues/400
branch
from
September 3, 2020 17:25
b94cd2d
to
4396819
Compare
Codecov Report
@@ Coverage Diff @@
## ci #405 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 69 69
Lines 1693 1693
Branches 388 388
=======================================
Hits 1566 1566
Misses 111 111
Partials 16 16
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
Sep 3, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 4, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 4, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 10, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 10, 2020
This was referenced Sep 10, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 16, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 16, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 29, 2020
cdcabrera
added a commit
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
.env.local
file it would be good to verify that date falls within the months of July/August/Sept 2020 or later/future. Otherwise even more "odd" displays may appear. Code will still functionHow to test
Env check
Steps to reproduce bug, an error should be throw and the GUI displays an error state
Proxy run check
$ yarn
$ yarn start:proxy
Example
...
Updates issue/story
Closes #400