Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): issues/400 page reset on limit update #405

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 3, 2020

What's included

  • fix(pagination): issues/400 page reset on limit update
  • chore(rhsmServices): expand system inventory mock

Notes

  • expanded mocks, update mock dates for rhsm subscription endpoints.
    • DEVELOPMENT - if you utilize a local run "date override" within a .env.local file it would be good to verify that date falls within the months of July/August/Sept 2020 or later/future. Otherwise even more "odd" displays may appear. Code will still function

How to test

Env check

Steps to reproduce bug, an error should be throw and the GUI displays an error state

  1. Locate an account with over 10 inventory listings
  2. navigate to the last offset/page with the paging controls
  3. select to increase the paging display limit

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. perform the same steps as the Env check, confirm no error is thrown

Example

...

Updates issue/story

Closes #400

@codecov-commenter
Copy link

Codecov Report

Merging #405 into ci will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #405   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          69       69           
  Lines        1693     1693           
  Branches      388      388           
=======================================
  Hits         1566     1566           
  Misses        111      111           
  Partials       16       16           
Impacted Files Coverage Δ
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/pagination/pagination.js 88.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343efe9...4396819. Read the comment docs.

@cdcabrera cdcabrera merged commit 07cccd6 into RedHatInsights:ci Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants