Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Sync, Dev to Test #409

Merged
merged 12 commits into from
Sep 10, 2020
Merged

Environment Sync, Dev to Test #409

merged 12 commits into from
Sep 10, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 4, 2020 •
edited
Loading

Bug Fixes

  1. graphCard,chartArea issues/365 increase stroke width (fix(graphCard,chartArea): issues/365 increase stroke width #392) (c8890ee)
  2. tableSkeleton allow table with zero rows (Display expandable guestsList for inventory, issues/10 #390) (e681073)
  3. guestsList issues/10 increase paging limit (Display expandable guestsList for inventory, issues/10 #390) (927743c)
  4. pagination issues/400 page reset on limit update (fix(pagination): issues/400 page reset on limit update #405) (84f8523)
  5. openshiftView issues/383 apply uom query filter (fix(openshiftView): issues/383 apply uom query filter #408) (e97a780)
  6. pagination,toolbar issues/400 page reset filter update (fix(toolbar): issues/400 page reset on filter update #412) (b26d35f)
  7. guestsList avoid boolean, remove nullish coalescing op (fix(toolbar,openshiftView): issues/400 page reset on filter update #413) (53f74c7)

Features

  1. guestsList issues/10 display infinite table listing (Display expandable guestsList for inventory, issues/10 #390) (88fa281)
  2. authentication issues/373 use platform not authorized (feat(authentication): issues/373 use platform not authorized #402) (969c331)

Styles

  1. pageLayout issues/391 remove gray padding (style(pageLayout): issues/391 remove gray padding #401) (6add46c)

Chores

  1. rhsmServices expand system inventory mock (fix(pagination): issues/400 page reset on limit update #405) (e2cf89e)
  2. build expand changelog displayed commits (chore(build): expand changelog displayed commits #415) (92617d7)

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #409 into qa will increase coverage by 0.34%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##               qa     #409      +/-   ##
==========================================
+ Coverage   92.42%   92.76%   +0.34%     
==========================================
  Files          68       70       +2     
  Lines        1651     1715      +64     
  Branches      382      394      +12     
==========================================
+ Hits         1526     1591      +65     
  Misses        109      109              
+ Partials       16       15       -1
Impacted Files Coverage Δ
src/components/authentication/authentication.js 60.00% <ø> (ø)
...c/components/inventoryList/inventoryListHelpers.js 100.00% <ø> (ø)
src/components/pageLayout/pageLayout.js 100.00% <ø> (ø)
src/redux/types/queryTypes.js 100.00% <ø> (ø)
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/rhelView/rhelView.js 88.88% <66.66%> (-3.97%) ⬇️
src/components/openshiftView/openshiftView.js 95.00% <83.33%> (-2.06%) ⬇️
src/components/guestsList/guestsList.js 97.82% <97.82%> (ø)
src/components/chartArea/chartArea.js 87.77% <100.00%> (+0.13%) ⬆️
src/components/graphCard/graphCard.js 84.31% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c889548...92617d7. Read the comment docs.

zanewoodfin and others added 8 commits September 3, 2020 21:23
@zanewoodfin @cdcabrera
fix(graphCard,chartArea): issues/365 increase stroke width (#392)
c8890ee
@cdcabrera
fix(tableSkeleton): allow table with zero rows (#390)
e681073
@cdcabrera
feat(guestsList): issues/10 display infinite table listing (#390)
88fa281 
* i18n, locale inventory header
* guestsList, add an infinite scrolling table component
* inventoryList, activate guestsList, missing annotations
* openshiftView, rhelView, pass guests lists filters
* apiQueries, rhsmApiTypes, guests schema for query-strings
* guestsListSelectors, cache removed, infinite scroll conflicts
* rhsmServices, mock for guests response
* style, file rename, table scroll
@cdcabrera
fix(guestsList): issues/10 increase paging limit (#390)
927743c
@zanewoodfin @cdcabrera
style(pageLayout): issues/391 remove gray padding (#401)
6add46c
@cdcabrera
fix(pagination): issues/400 page reset on limit update (#405)
84f8523
@cdcabrera
chore(rhsmServices): expand system inventory mock (#405)
e2cf89e
@zanewoodfin @cdcabrera
feat(authentication): issues/373 use platform not authorized (#402)
969c331
@cdcabrera cdcabrera changed the title WIP Environment Sync, Dev to Test Environment Sync, Dev to Test Sep 4, 2020
@cdcabrera
fix(openshiftView): issues/383 apply uom query filter (#408)
e97a780 
* i18n, uom strings
* openshiftView, filter, default props avoid 2x XHR on load
* redux, queryTypes, viewReducer, sort statements, uom filter
* rhsmApiTypes, uom types
@cdcabrera
fix(pagination,toolbar): issues/400 page reset filter update (#412)
b26d35f 
* openshiftView, pass productId to toolbar, page reset helper
* pagination, productId as primary state update
* paginationHelper, centralize page reset
* rhelView, pass productId to toolbar
* toolbar, page reset helper on filter selection and clear
@cdcabrera
fix(guestsList): avoid boolean, remove nullish coalescing op (#413)
53f74c7
@cdcabrera cdcabrera merged commit 63a72f9 into qa Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdcabrera @codecov-commenter @zanewoodfin